Add event for splash screen closing in DynamoRevit.

DynamoDS / DynamoRevit

Dynamo Libraries for Revit

https://dynamobim.org

334 stars 187 forks source link

Add event for splash screen closing in DynamoRevit. #2886

Closed reddyashish closed 1 year ago

reddyashish commented 1 year ago

Purpose

This is to add a event that will shut down the Dynamo model and enable Dynamo icon in Revit.

Declarations

Check these if you believe they are true

[ ] The code base is in a better state after this PR
[ ] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] Snapshot of UI changes, if any.

Reviewers

@QilongTang @mjkkirschner

wangyangshi commented 1 year ago

thank you, Aaron, for the fixing, will this come into effective after merging new DC?

QilongTang commented 1 year ago

thank you, Aaron, for the fixing, will this come into effect after merging new DC?

Yes, once the new DynamoCore is out and integrated, the close button on Splash screen should work and re-enable Dynamo button. We are currently waiting for localization to be done.

reddyashish commented 1 year ago

@wangyangshi @QilongTang I don't have merge access to this. Can any of you do it.