search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Greg update #2887

Closed wangyangshi closed 1 year ago

wangyangshi commented 1 year ago

Purpose

https://jira.autodesk.com/browse/REVIT-196808 1 update greg version in Revit 2022 2 newtonsoft references Revit 2022

Declarations

reference: https://github.com/DynamoDS/DynamoRevit/pull/2885 https://github.com/DynamoDS/DynamoRevit/pull/2757 https://github.com/DynamoDS/DynamoRevit/pull/2756

mjkkirschner commented 1 year ago

hmm, I think using these version numbers is safe - we know they worked together in 2023.

@wangyangshi I am not sure that updating to use RevitOAuth2Provider will work in Revit 2022, 21 etc - I don't think that is actually necessary as we did not remove the RevitOxygenProvider from GregRevitAuth.dll

I think either is fine if you are sure that Revit 2022,21, 20's SSONet provides the correct methods to get an oauth2 token etc.

Will Revit QA have time to test the following?

  1. test package upload (can be done against package manager dev by just changing the DynamoPackages.config file to point to https://dev.dynamopackages.com
  2. retest the original bug - IE load SpaceMaker addin first, start it, then try to start DynamoRevit and confirm it starts correctly.

I think testing in each hotfix version - if there are going to be others to 2021,20 etc would be ideal.

wangyangshi commented 1 year ago

@mjkkirschner OK, if RevitOxygenProvider can still work, what about keep it, I want to change less, affect less to old releases.

mjkkirschner commented 1 year ago

@mjkkirschner OK, if RevitOxygenProvider can still work, what about keep it, I want to change less, affect less to old releases.

I think that makes sense for hot fixes.