DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Handle additional cases for splash screen events. #2891

Closed reddyashish closed 1 year ago

reddyashish commented 1 year ago

Purpose

This PR is to address the following cases: 1) Disabling the Dynamo button in Revit as soon as the splash screen is created. This will not allow multiple instances being launched, when the splash screen is loading. 2) Disabling the Dynamo button when Dynamo main window is launched from splash screen. 3) Setting the parent for splash screen window.

Declarations

Check these if you believe they are true

Reviewers

@QilongTang @wangyangshi

wangyangshi commented 1 year ago

set splash screen's parent as revit window. I think should be like: IntPtr mwHandle = commandData.Application.MainWindowHandle; new WindowInteropHelper(splashScreen).Owner = mwHandle; similar to InitializeCoreView

wangyangshi commented 1 year ago

which dynamo core version can be tested with the interface OnRequestLaunchDynamo?

reddyashish commented 1 year ago

latest 2.17 build: DynamoCoreRuntime_2.17.0.3467

mjkkirschner commented 1 year ago

@reddyashish I think a nuget push is needed?

reddyashish commented 1 year ago

@mjkkirschner DynamoCoreRuntime Nuget? That version is present https://art-bobcat.autodesk.com/ui/repos/tree/General/team-dynamo-nuget/DynamoVisualProgramming.DynamoCoreRuntime.2.17.0.3467.nupkg

mjkkirschner commented 1 year ago

If you wish to have the new API buildable in DynamoRevit then it needs to be pushed to public nuget in the DynamoCore nuget etc. (not artifactory)

this repo does not reference the artifactory nugets (it should be buildable for third parties outside adsk)

QilongTang commented 1 year ago

@mjkkirschner @reddyashish I have pushed the newer version for you

reddyashish commented 1 year ago

Thanks @QilongTang. I added the change to set Revit window as the owner of splash screen window.