search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
338 stars 188 forks source link

Upgrade DynamoCore Lib to involve new version of Sample rvt file. #2897

Closed wangyangshi closed 1 year ago

wangyangshi commented 1 year ago

upgrade sample rvt file

Reviewers

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

wangyangshi commented 1 year ago

@QilongTang Hi Aaron I change these version to 2.18.0-beta3734, but in DynamoRevitUtil, still keep dynamo core version as 2.17.0.3472 https://git.autodesk.com/Dynamo/DynamoRevitUtils/blob/5bc7844345781fa3a12c1ead21815f57f61c926d/BuildSolutions.bat#L16

is it right? I referred to this: https://github.com/DynamoDS/DynamoRevit/pull/2787/files

QilongTang commented 1 year ago

hmm.. I feel you only need to change the version of the sample nuget, these versions do not need to always align to the same minor number. What do you think @mjkkirschner

wangyangshi commented 1 year ago

@QilongTang thank you I will change only the sample version

wangyangshi commented 1 year ago

https://git.autodesk.com/Dynamo/DynamoRevitUtils/pull/86 at DynamoRevitUtils, in the build script, DynamoSamples use the version of DynamoVisualProgramming.Core, so I change it to 2.18.0-beta3734 instead of DCoreVersion