Fix DynamoPlayer when splash screen is enabled.

reddyashish commented 1 year ago

Purpose

Shows splash screen in Revit 2024 and fixes Dynamo player. Task: https://jira.autodesk.com/browse/DYN-5489

When Dynamo is started from Revit, we will show the splash screen, which will load the dynamo window. When Dynamo player is started, we will initialize RevitDynamoModel in UIless mode. This is done by checking the commandData for JournalKeys.ShowUiKey and if it is false, we will start in UIless mode.

dynamo player fix

Declarations

Check these if you believe they are true

[ ] The code base is in a better state after this PR
[ ] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] Snapshot of UI changes, if any.

Reviewers

@QilongTang @mjkkirschner @wangyangshi

FYIs

reddyashish commented 1 year ago

I don't have write access to this repo. Can any of you merge it?

QilongTang commented 1 year ago

@Mikhinja Splash screen feature has been heavily tested in the past but blocked by this bug. Now that it is fixed, it would be good if your team gives it a shot for the R2024.1 release. Thanks for the review work!

DynamoDS / DynamoRevit