Closed reddyashish closed 1 year ago
hey @reddyashish @QilongTang -nice that this is possible - but do you think it would be better if this was just an option in DynamoCore instead so that integrators would not have to do anything special to accomplish this? (maybe an improvement for the future)
@mjkkirschner There is already a setting in Dynamo for this. FYI: @reddyashish does it work when you have the setting turned on?
That setting is for static splash screen. Dynamic splash screen is always shown. @mjkkirschner you mean an option to load the Dynamic main window(without the dynamic splash screen) from Core? Yes that would be ideal. I thought, since splash screen is a webview2 component and not inside core, DynamoRevit was linked to splash screen directly.
hey @reddyashish @QilongTang -nice that this is possible - but do you think it would be better if this was just an option in DynamoCore instead so that integrators would not have to do anything special to accomplish this? (maybe an improvement for the future)
I feel like I want your elaboration on this
yeah, I don't have a solution in mind, it just feels to me that the splash screen is too complex, and using it has become quite complex for integrators, and we should redesign the API for using it so all they need to think about is - I want to start dynamo with a splash screen or without.
@mjkkirschner That make sense. @reddyashish It looks like to me, that a setting is needed to totally skip even the static splash. But it might be too late for 2.18 release. Also can you attach a gif about the behavior before and after?
yeah agree regarding 2.18 - this is more a comment in general about splash screen / API consideration in general for the future.
Before this, a lot of splash screens were starting and it would crash.
@Mikhinja Can you merge this if it looks good to you. I don't have write access.
Purpose
Option to launch Dynamo directly without splash screen. This is a follow-up of https://github.com/DynamoDS/DynamoRevit/pull/2913 after enabling splash screen in Revit. @BogdanZavu reported that player samples were not being edited with the latest changes.
When Dynamo player samples are edited, main dynamo is needed and it should start a example workspace. So we need a option to launch main Dynamo directly in that case.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @Mikhinja