DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
333 stars 186 forks source link

Changes on D4R side to complement Graphic Helpers Update #13895 #2915

Closed dnenov closed 1 year ago

dnenov commented 1 year ago

Purpose

CANCELLED - based on RC2.16.1_Revit2023, was superseded by https://github.com/DynamoDS/DynamoRevit/pull/2920.

To be used in conjunction with https://github.com/DynamoDS/Dynamo/pull/13895! This PR creates an entry inside Dynamo's PreferenceSettings which track the current document's units inside Revit. This is used to help scale background graphics relative to the current project settings thus making the background helpers inside Dynamo more useful.

setting Revit units to scale Dynamo grids

Declarations

Check these if you believe they are true

Reviewers

@reddyashish @Amoursol

FYIs

Amoursol commented 10 months ago

@Mikhinja just checking this is making it into Revit 2024.2? 😊

Mikhinja commented 10 months ago

@Amoursol Looks like yes: https://github.com/DynamoDS/DynamoRevit/blob/RC2.19.0_Revit2024.2/src/DynamoRevit/DynamoRevit.cs#L410