DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
336 stars 187 forks source link

3DView Template Wrapper #2916

Closed dnenov closed 1 year ago

dnenov commented 1 year ago

Purpose

This PR adds a Wrapper for the 3D View Template. Previously showing as 'null'.

3dviewtemplate

Declarations

Check these if you believe they are true

Reviewers

@Amoursol @reddyashish

FYIs

@mjkkirschner

Mikhinja commented 1 year ago

@reddyashish Is this change still targeting Revit 2023? I assume the changes should be targeting master branch instead.

reddyashish commented 1 year ago

@Mikhinja yes, all the PR's are being changed to target master branch.

QilongTang commented 1 year ago

We should re-base this PR then

reddyashish commented 1 year ago

Just rebasing won't work because the source branch is cloned from Revit2023 branch. This will have a lot more changes if we just rebase to master.

QilongTang commented 1 year ago

Just rebasing won't work because the source branch is cloned from Revit2023 branch. This will have a lot more changes if we just rebase to master.

Thanks, given we are touching only 3 files, let's re-create this PR

dnenov commented 1 year ago

Recreated pointing to master https://github.com/DynamoDS/DynamoRevit/pull/2925, closing this PR.