DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
333 stars 186 forks source link

New node Element.GetGeometry #2918

Closed dnenov closed 1 year ago

dnenov commented 1 year ago

Purpose

Part of the new nodes PRs, this small PR adds a new Element.GetGeometry node, which incorporates an input for Detail Level.

getgeometry

Check these if you believe they are true

Reviewers

@reddyashish @Amoursol

FYIs

mjkkirschner commented 1 year ago

wheres the tests ;)?

dnenov commented 1 year ago

wheres the tests ;)?

Tests or it didn't happen :)))

I added the test for this node. We have 2 bigger PRs coming up, but I'd rather have them merged first before creating a separate PR with tests for them, if that's OK. So, more tests should be coming up for those.

dnenov commented 1 year ago

Recreated to master branch https://github.com/DynamoDS/DynamoRevit/pull/2924, closing this PR.