Re dynamorevit linkinstancenodes

DynamoDS / DynamoRevit

Dynamo Libraries for Revit

https://dynamobim.org

333 stars 186 forks source link

Re dynamorevit linkinstancenodes #2922

Closed dariaivanciucova closed 1 year ago

dariaivanciucova commented 1 year ago

Purpose

Re-do of https://github.com/DynamoDS/DynamoRevit/pull/2909 PR.

This PR contains several new nodes for Dynamo Revit. The nodes fall under LinkInstance and Document category.

Document.GetLinkInstances
LinkInstance.AllElementsOfCategory
LinkInstance.AllElementsOfCategoryInView
LinkInstance.AllElementsOfClass
LinkInstance.AllElementsAtLevel
LinkInstance.ByName
LinkInstance.ByTitle
LinkInstance.Document
LinkInstance.ElementById
LinkInstance.UniqueId

Declarations

Check these if you believe they are true

[x] The code base is in a better state after this PR
[x] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] Snapshot of UI changes, if any.

Reviewers

@Amoursol @hwahlstrom

FYIs

@dnenov

dariaivanciucova commented 1 year ago

Note! Currently targeting Revit 2024 dlls, to be able to build. There are changes inside multiple project files where the references have been updated. Potentially these need to be removed from the PR before merging, but on a few occasions, there are valid changes to the project files that need to be kept.

dariaivanciucova commented 1 year ago

Note! Currently targeting Revit 2024 dlls, to be able to build. There are changes inside multiple project files where the references have been updated. Potentially these need to be removed from the PR before merging, but on a few occasions, there are valid changes to the project files that need to be kept.

This should now be resolved

reddyashish commented 1 year ago

Thanks @dariaivanciucova Looks good with couple of comments.

dariaivanciucova commented 1 year ago

@reddyashish tested - all works as expected

reddyashish commented 1 year ago

@Mikhinja All good for this PR. It can be merged.

dariaivanciucova commented 1 year ago

hey @Mikhinja , can you merge this please?

dnenov commented 1 year ago

Hi @Mikhinja - would it be OK if we were to merge this PR, since it's quite old now and we are having major issues when building against the old RevitAPI.dll and RevitAPIUI.dll and the special version of dynamocore.dll .. basically it's quite the nightmare to make a clean PR, but keep a stash full of references to allow us to work on it. I was hoping that after merging this PR, we can have a clean and crisp build against the latest Master that doesn't have any of these issues. We can then take work on all the comments, if that's OK.

Mikhinja commented 1 year ago

@dnenov Sure thing.