Re graphichelperupdates - Githubissues

DynamoDS / DynamoRevit

Dynamo Libraries for Revit

https://dynamobim.org

333 stars 186 forks source link

Re graphichelperupdates #2923

Closed dnenov closed 1 year ago

dnenov commented 1 year ago

Purpose

A short update to https://github.com/DynamoDS/DynamoRevit/pull/2920 due to recent refactoring on the Dynamo side of this task. For more information refer to https://github.com/DynamoDS/Dynamo/pull/13895/commits/1562a2eaeaac27ea889250c60254d55c679c6fac.

Declarations

Check these if you believe they are true

[x] The code base is in a better state after this PR
[x] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] Snapshot of UI changes, if any.

Reviewers

@reddyashish

FYIs

@Amoursol

reddyashish commented 1 year ago

LGTM, should be merged with https://github.com/DynamoDS/Dynamo/pull/13895

reddyashish commented 1 year ago

@Mikhinja this should be ready to merge. Just changing the field name according to the changes in Dynamo.