DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
336 stars 187 forks source link

Pass the Preferences as part of the Initializacion configuration #2933

Closed jesusalvino closed 1 year ago

jesusalvino commented 1 year ago

Purpose

As part of the task https://jira.autodesk.com/browse/DYN-5816 the DynamoModel that the class RevitDynamoModel inherits, needs to pass the explicit Preferences as part of its initialization configuration.

Declarations

Check these if you believe they are true

Reviewers

@QilongTang @reddyashish

QilongTang commented 1 year ago

@Mikhinja PTAL, please refer to https://github.com/DynamoDS/Dynamo/pull/14118

QilongTang commented 1 year ago

hi @Mikhinja This is a pairing change to work with the RC2.19.0 build

mjkkirschner commented 1 year ago

Does this cause the multiple instance bug shown on slack?

jesusalvino commented 1 year ago

Does this cause the multiple instance bug shown on slack?

I Don't think so since I have tested a branch before this change, but looks like it's an issue that only pass for my local setup