search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
328 stars 184 forks source link

DYN-6259 #2972

Closed jesusalvino closed 9 months ago

jesusalvino commented 9 months ago

Purpose

Fixing the bug https://jira.autodesk.com/browse/DYN-6259 excluding passing the Preferences due to it will be handled in the DynamoModel side based on the PathManager info. Follow up PR of https://github.com/DynamoDS/Dynamo/pull/14427

Declarations

Check these if you believe they are true

Reviewers

@QilongTang @reddyashish

QilongTang commented 9 months ago

So this is reverting https://github.com/DynamoDS/DynamoRevit/pull/2933?

jesusalvino commented 9 months ago

So this is reverting #2933?

yes

Mikhinja commented 9 months ago

If testing passes, can we make sure to also merge in branches RC2.19.0_Revit2025 and RC2.19.0_Revit2024.2, please?

QilongTang commented 9 months ago

@jesusalvino Would you initiate the cherry-pick?

jesusalvino commented 9 months ago

@jesusalvino Would you initiate the cherry-pick?

Done:

https://github.com/DynamoDS/DynamoRevit/pull/2975 https://github.com/DynamoDS/DynamoRevit/pull/2976