Closed johnpierson closed 9 months ago
For categories, element classes, family types and ceiling types I have expanded them.
On Fri, Sep 29, 2023 at 3:45 PM Lilli Smith @.***> wrote:
@.**** commented on this pull request.
On doc/distrib/NodeHelpFiles/DSRevitNodesUI.Sheets_img.jpg https://github.com/DynamoDS/DynamoRevit/pull/2980#discussion_r1341817500 :
@johnpierson https://github.com/johnpierson did we say for these selection nodes we were going to do a different kind of sample - one with more nodes? because just having the 1 node that you've already F1ed isn't really useful to insert? I would thing we would probably want to feed this into a get parameter node?
— Reply to this email directly, view it on GitHub https://github.com/DynamoDS/DynamoRevit/pull/2980#pullrequestreview-1651517497, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VHX32R233NXUEO7CBLX446OZANCNFSM6AAAAAA5NAF3FE . You are receiving this because you were mentioned.Message ID: @.***>
@hwahlstrom , made those changes now. Let me know if everything looks good and I can get round 2 (the Revit.Elements.Element category in Dynamo) submitted.
LGTM
The first round of selections category for node help in the documentation browser.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
To add node help for the selection nodes (about 30 so far)
Declarations
Check these if you believe they are true
*.resx
filesReviewers
Helena Wahlstrom, @lillismith
FYIs
@QilongTang