LinkElement unloaded links bug fix and LinkInstance name change - Githubissues

DynamoDS / DynamoRevit

Dynamo Libraries for Revit

https://dynamobim.org

328 stars 184 forks source link

LinkElement unloaded links bug fix and LinkInstance name change #2993

Closed dariaivanciucova closed 8 months ago

dariaivanciucova commented 8 months ago

Purpose

This PR fixes a bug that's occurring for LinkInstance and LinkElement nodes when one of the Links is unloaded. The bug is recorded here

This fix addresses the following scenarios:

one of the links is unloaded - all nodes using a loaded link as input work as expected and return results (previously showing an error)
the unloaded link is used as input for nodes such as 'AllElementsOfCategory' will return null (previously showing an error). This can happen if the LinkInstance was previously loaded and then unloaded, returned by ByName node or Document.GetLinkInstances node.

This PR also reverts back to the class name LinkInstance from RevitLinkInstance

Declarations

Check these if you believe they are true

[x] The code base is in a better state after this PR
[x] Is documented according to the standards
[x] The level of testing this PR includes is appropriate
[x] User-facing strings, if any, are extracted into *.resx files
[x] Snapshot of UI changes, if any.

Reviewers

@reddyashish @Mikhinja

FYIs

@dnenov @Amoursol

dariaivanciucova commented 8 months ago

@Mikhinja this is the fix for https://jira.autodesk.com/browse/DYN-6376, can you review please?