DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
340 stars 188 forks source link

Nuget package 2.19 include 3.0 assembly #3071

Open erfajo opened 6 months ago

erfajo commented 6 months ago

Dynamo Version

2.19.5.8116

Revit Version

2024

Operating System

Windows11

What did you do?

I am using nuget packages to compile my own package, and when downloading nuget package for 2.19 it includes ProtoGeometry.dll for 3.0, and that gives errors!!!! image

What did you expect to see?

ProtoGeometry.dll for 2.19.5 version

What did you see instead?

ProtoGeometry.dll for 3.0 version

Stacktrace/logs

No response

Details

No response

avidit commented 6 months ago

@mjkkirschner @aparajit-pratap any insights?

erfajo commented 6 months ago

Just for the record, I replaced it with the latest released by Revit updates, and that works perfect... image

mjkkirschner commented 6 months ago

it's from this PR: https://github.com/DynamoDS/Dynamo/pull/15029/files FYI @sm6srw

Hi @erfajo thanks for reporting - can you share the errors you get when using 3.0 protogeometry.dll in a 2.19 context? Are they compile time, runtime or both?

erfajo commented 6 months ago

Sorry for being imprecise, it is a runtime error, while loading my assembly, due to it using ProtoGeometry of a newer version than loaded by the dynamo platform. I don’t get any compile-time errors. image

erfajo commented 5 months ago

I can see that some users on the dynamobim forum complain that Orchid doesn't work, however, I don’t have an account to the forum anymore due to how that site is handled, so I can't explain to users that the error is due to the assembly problem caused by using the .nuget packages released by you in the team.

Maybe you should act quite fast so others don’t end up where I have ended and/or put it up in the forum that using .nuget packages is causing issues at the moment if a package includes references to at least the ProtoGeometry assembly file, however, I cant quarentee that there aren’t other issues due to the .nuget releases.

I have now released a new version of my package so I at least don't have this error issue anymore...