EIRTeam / Project-Heartbeat

Project Heartbeat source code release
65 stars 9 forks source link

Discrepancy in replays #115

Open EIRTeam-Cirno opened 3 days ago

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Replays seem to be hitting notes differently to how they were actually hit and in some cases even misses notes image.pngimage.pngimage.png

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

The first screenshot is after playing the replay

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

the second screenshot is the replay I selected

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

the third screenshot is the actual score I got

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Playing the same replay again gets different results image.png

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

I think this is the replay file

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

It does seem to get the fines, safes and sads right each time though image.png

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

well, it gets the same number each time, but is different than the actual score

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

🤔

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

i'll check

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

are you using DJA?

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

yup

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

mmh

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

I recorded my actual gameplay with obs so I'm trying to find where the discrepancy starts

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

did you do anything out of the ordinary during that session like restarting or something?

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

nope

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

just played from start to finish

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

ok so the first discrepancy is when ending a double sustain.

Replay: the double sustain with <:Square:818564182861545524> <:Cross:818564157296083034> doesn't end properly and so the next note becomes a worst

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Original: the double sustain ends properly

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

thanks, at least that narrows it down

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

I think most of the discrepancies are with sustain ends tbh

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

might be an issue to do with rate limiting

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

mmmh

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Next discrepancies are with heart sustain endings

Replay:

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Original:

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

nop it wasn't rate limiting

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

perhaps its an issue only with controllers

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

The next disprepancy seems to be with arrow notes

EIRTeam-Cirno commented 3 days ago

Steven Steven BOT

sustains are definitely part of the issue, i got it to break on a chart that's only sustains haven't been able to get any discrepancies on arcade charts

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

can you send me an isolated replay and chart?

EIRTeam-Cirno commented 3 days ago

Steven Steven BOT

https://steamcommunity.com/sharedfiles/filedetails/?id=2955656117 if any chart could break replays, it's definitely this one <:PokeSlow:663445671852113950>

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Arrows seem to be a lot more intermittent. it changes every time I play the replay

Replay:

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Original:

EIRTeam-Cirno commented 3 days ago

Pascal Pascal BOT

I like how for once it's not holds breaking things.

EIRTeam-Cirno commented 3 days ago

Steven Steven BOT

could it perhaps relate to using macros to swap sustains or hit doubles?

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

maybe

EIRTeam-Cirno commented 3 days ago

Steven Steven BOT

you mentioned something about rate limiting, that sounds like it could portentially cut important inputs from the history

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

I hit arrows just with the face buttons btw

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

and sustains actually

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

definitely the heart ones haha

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

oh yeah but i checked it and it doesn't cut things if said action had press or release events

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

i think

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

i'll disable it and we can try

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

Could it be something like this? so like there was a heart and then straight after it, there was a heart sustain. if I hit the heart sustain before I release the first heart, could that mess with it somehow? Maybe it thinks I'm still holding that first heart input?

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

first run on yahoo plays back fine for me... could this be a windows moment? 🤔

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

we love windows

EIRTeam-Cirno commented 3 days ago

Slash Slash BOT

lemme play yahoo

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

it would be good if you could find a shorter song to trigger it 🐸

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

yup, plays back fine for me wtf

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

can you guys send me your user_settings.json or something?

EIRTeam-Cirno commented 3 days ago

EIREXE EIREXE BOT

I wonder if timing adjustment is messing with it