search

EIRTeam / Project-Heartbeat

Project Heartbeat source code release
70 stars 9 forks source link

Discrepancy in replays #115

Closed EIRTeam-Cirno closed 1 month ago

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Replays seem to be hitting notes differently to how they were actually hit and in some cases even misses notes image.pngimage.pngimage.png

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

it shouldn't but

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i have a 4ms global offset

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

yahoo seems to be playing back fine for me too

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

it missed an additional note during my playback

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

yeah even with an offset it played back fine for me wtf

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

i'll try slash's replay

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

mine played back fine for yahoo

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I'll try and find a smaller song

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

although I don't have many small songs haha

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i modified yahoo to have one set of two double sustains and be 14 seconds long replaying got me 2 misses on the sustain finishes that didn't happen in the original

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

perfect, ty

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

it consistently misses the sustain releases for me

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

yep, does that for me too

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

i'll take a look

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

this was prior to the update that you pushed, does that update change anything relevant?

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

i disabled rate limiting, but i don't think it will change anything

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

it doesn't with the playback, but i haven't been able to make a new replay desync

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

yeah the existing replay won't be affected

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

maybe that was it then 🤔

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

oh is there another update?

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

nope i got it to trigger again

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

can you do the same without moving the analog sticks? that adds a lot of events and makes debugging harder 🐸

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i can try though weirdly the only two times i've gotten it to desync are when i spammed buttons at the start

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

i wonder if that was related

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

other songs seem to be working fine

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

maybe it's just with fast songs?

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

perhaps

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

I was thinking of out of order events but those aren't stored

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

as in, its properly stored by order

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i got it to work again while spamming buttons at the beginning, but no luck when not spamming buttons i didn't press the sticks, but I'm noticing it's bigger than the one i sent earlier, so it probably won't help much with debugging <:PokeSlow:663445671852113950>

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

what a weird issue

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

well I played a fast song and it didn't even try to record it haha image.png

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I'll try again later

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

there's a shit ton of gamepad button events at the start of the replay <:PokeWHAT:692184145878843415> steven sent for some reason

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

<:PepeFlower:945550232157040660> i told you i spammed buttons

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

no but this is too much me thinks

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

probably the quint macros on L2/R2

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

and double + slides on L1/R1

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

right

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

quint macros on l2/r2 would be counted as input axis events actually

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

for what it's worth, i've been unable to replicate it without some kind of analog input being spammed at the start

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

just face buttons and face + L1/R1 hasn't triggered it yet

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

but L2/R2 solo did trigger it

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

oh I wonder if it couldn't make the raid boss file because the song name has a colon image.png

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

<:perhaps:809841654067888138>

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

it's definitely fast songs, it was dropping notes left right and center

Replay: image.png

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Original: image.png

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i was also finally able to desync on an arcade chart

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Event at the very start when the song is slow it was dropping notes

Replay: