EIRTeam / Project-Heartbeat

Project Heartbeat source code release
70 stars 9 forks source link

Discrepancy in replays #115

Closed EIRTeam-Cirno closed 1 month ago

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Replays seem to be hitting notes differently to how they were actually hit and in some cases even misses notes image.pngimage.pngimage.png

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Original:

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

it's also quite laggy when changing to the replay tab now after playing that song a few times

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

heyyy this replay beat my score! image.png

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I tried playing a slow song that was really long (like 10 mins or something) and that also seems to drop notes, but not as often

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

however now later on in the song it's dropping lots of notes

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

just for the record, I did hit all those notes haha

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

yeah no need to test anymore, I know where the issue lies, just need to figure out what it is

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Cool

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

<@219966809833472010> you said it wasn't possible to cause the problem without macros?

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

because a macroless reproductiojn would make my life a lot easier

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

I never got it to work without pressing a macro'd key, but I believe <@934139325283696670> wasn't using macros.

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

I just had a bug brain idea

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

I wonder if the issue is caused by some form of interaction between different analog inputs bound to the same action

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Yeah like 99% of the song I was using face buttons

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I can try playing a song with absolutely 0 macros

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I'll play with just the face buttons, no shoulder and no analog sticks

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

ok I did it and the replay is just... really fcking bad hahaha

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

it misses almost every note

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

something I've noticed is that switching to the replay tab is really slow too, even for songs which don't have replays

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

maybe the replay itself is just really laggy or something

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

however after unpausing the replay, it seems to be hitting the notes more normally

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

Here's the replay

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

and here's the original stats that I got image.png

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I didn;t hit any of the hearts, all I use were face buttons

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

I'm gonna try deleting all my replays and doing it again to see if that changes anything

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

it was more accurate this time, but still dropped some notes

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

keep in mind that watching the replay multiple times results in different dropped notes each time

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

so it may actually be recording the inputs correctly, it just doesn;t play them back right

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

chat I think I found it

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

please try now, I think I mended the issue

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

<@219966809833472010>

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

try with new replays?

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

ye, old ones have invalid data

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

still got a replay with some extra missed notes going to try to do it on a shorter chart, though

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

ok so I've done a test where I only used face buttons and the replay is working fine

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

gonna try with macros and slides now

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

macros and slides replay still missed some notes

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i can't seem to make it happen on a simple chart, though

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

aaaand that first replay with just face buttons just returned a different score

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

how do I check if I actually have the update?

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

i mean if you close it and there isn't an update pending then you probably have it you could verify integrity of game files to guarantee you're on the latest patch

EIRTeam-Cirno commented 3 months ago

Slash Slash BOT

yeah no pending update

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

inb4 eir didn't push the update <:PokeSlow:663445671852113950> i verified game files and went to do something else during the two minute wait to verify all the workshop content, so there's a chance

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

nah i'm pretty sure I did push it

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

lemme check

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

game should report 23:11:52 build time

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

and i presume it's not a localized time <:PokeSlow:663445671852113950> image.png

EIRTeam-Cirno commented 3 months ago

Steven Steven BOT

actually now that i look it probably is localized, unless you just happened to built it on the same minute and second

EIRTeam-Cirno commented 3 months ago

EIREXE EIREXE BOT

hmmm how odd that it doesn't work though