EOX-A / QgsWcsClient2

A QGis WCS2.0/EO-WCS Plugin
Other
3 stars 2 forks source link

Wrong Select Sections in DescribeEOCoverageSet #16

Closed vskorole closed 6 years ago

vskorole commented 6 years ago

Requirement 55 /req/eowcs/describeEOCoverageSet-response-section- coverageDescriptions: If a DescribeEOCoverageSet request contains a sections parameter then a successful re- sponse shall contain a wcs:CoverageDescriptions element if and only if the section parameter list contains one of the values \u201cCoverageDescriptions\u201d or \u201cAll\u201d. Requirement 56 /req/eowcs/describeEOCoverageSet-response-section- datasetSeriesDescriptions: If a DescribeEOCoverageSet request contains a sections parameter then a successful re- sponse shall contain a eowcs:DatasetSeriesDescriptions element if and only if the section parameter list contains one of the values \u201cDatasetSeriesDescriptions\u201d or \u201cAll\u201d.

Current options: All, DataSeriesSummary, CoverageSummary

vskorole commented 6 years ago

What did you do to fix this issue?

eox-cs1 commented 6 years ago

Dear vskorole, the section parameter is only used in the GetCapabilities request, but not in the DescribeEOCoverageSet requests. You can verify this if you open the python-console within QGis and then the QgsWcsClient2. The requests (and other selections) are then printed to the python-console. I hope this answers your inquiry reagards Christian

vskorole commented 6 years ago

Dear Christian, Your answer is not quite good enough. If you don’t use “sections” in the DescribeEOCoverageSet then why do you put checkboxes in the form? In this case you confuse users and should remove checkboxes.

Slav Korolev Work : 301-851-8339 Cell: 240-481-4003 Slav.korolev@nasa.govmailto:Slav.korolev@nasa.gov Vyacheslav.s.korolev@raytheon.com

From: Christian notifications@github.com Reply-To: EOX-A/QgsWcsClient2 reply@reply.github.com Date: Tuesday, May 15, 2018 at 12:47 To: EOX-A/QgsWcsClient2 QgsWcsClient2@noreply.github.com Cc: vskorole slav.korolev@nasa.gov, Author author@noreply.github.com Subject: Re: [EOX-A/QgsWcsClient2] Wrong Select Sections in DescribeEOCoverageSet (#16)

Dear vskorole, the section parameter is only used in the GetCapabilities request, but not in the DescribeEOCoverageSet requests. You can verify this if you open the python-console within QGis and then the QgsWcsClient2. The requests (and other selections) are then printed to the python-console. I hope this answers your inquiry reagards Christian

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/EOX-A/QgsWcsClient2/issues/16#issuecomment-389235704, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AazF8xEipnotwG5RAT5Jqf6yH8Am_pI0ks5tywaqgaJpZM4T4VMp.

eox-cs1 commented 6 years ago

Dear vskorole, These checkboxes were added on a users-request. I didn't have them in the initial version. For me it was clear that the checkboxes on the GetCapabilities Tab only apply to the GetCapabilities. Sorry if that caused some misunderstanding. regards Christian

eox-cs1 commented 6 years ago

Dear vskorole, I checked again, there is also the possibility to set section= 'All', 'DatasetSeriesSummary' or 'CoverageSummary' with the DescribeEOCoverageSet Request. If selected the requests (see python console), are IMHO correctly formed. What the queried WCS server delivers back to my client is beyond my control. Hope this clarifies. best regards Christian

vskorole commented 6 years ago

I found the problem in qgswcsclient2dialog.py line 991: req_params = {'version': offered_version, 'request': 'DescribeEOCoverageSet', 'server_url': selected_url, 'eoID': selected_eoid, 'subset_lon': req_lon, 'subset_lat': req_lat, 'subset_time': req_toi, 'containment' : req_contain, 'count' : req_count, 'section' : req_sections, 'IDs_only': req_IDs_only} In console I get: DCS: {'server_url': u'http://localhost:8084/egi_my/request?version=2.0.1&', 'IDs_only': False, 'eoID': 'TL3CH4D.002', 'count': '1', 'section': 'DatasetSeriesDescriptions', 'request': 'DescribeEOCoverageSet', 'version': '2.0.1', 'containment': 'overlaps'}

Should be 'sections' : req_sections, !!!

eox-cs1 commented 6 years ago

Dear vskorole, this has now been fixed with release 0.3.2 (just gone online)

your input above didn't cover the actual bug causing the misbehaviour, but it pointed me in the right direction, so it was very helpful. Sorry for the overall delay with the fix, but I was busy with other things... Christian