search

ESCOMP / SimpleLand

Simple Land Model for CESM --- *** IN DEVELOPMENT *** --- please contact for more info. See supplemental information of https://journals.ametsoc.org/doi/abs/10.1175/JCLI-D-18-0812.1 for a description of SLIM physics. Implementation of SLIM into the main CESM trunk is ongoing. SLIM currently works with the CESM2.1 release, but must be downloaded from this repository until we finish implementing it properly into the main CESM code.
Other
12 stars 7 forks source link

Remove options not used, e.g. use_fates, use_cndv, and many more #46

Closed slevis-lmwg closed 1 year ago

slevis-lmwg commented 1 year ago

Resolves #44 (I will continue updating my notes there for now) Resolves #50

Collaborators: @ekluzek

ekluzek commented 1 year ago

With #50 I showed that it's safe to remove use_cn and BGC code.

slevis-lmwg commented 1 year ago

The last commit (https://github.com/ESCOMP/SimpleLand/pull/46/commits/aa77f2a9eb26da77b78462a2d41e9afb857c843a) reverted to a commit that had removed use_cn and canceled a subsequent commit that had removed co2_ppmv and co2_type because in the latter I started seeing diffs from baseline.

slevis-lmwg commented 1 year ago

For the record: I have now tested this commit https://github.com/ESCOMP/SimpleLand/pull/46/commits/be98eb692d84ded65174cd28881ed99f248fe436 also on cheyenne and it's OK, plus a test that was failing now passes: SMS_Lm3.f19_g16.H_MML_2000_CAM5.cheyenne_gnu.clm-global_uniform_g16_SOM

slevis-lmwg commented 1 year ago

I tried git ls-files | xargs wc -l on the latest commit and got current number of lines: 67887 Goal is about 46000

Also I ran both test-suites on the latest commit and izumi OK cheyenne OK

slevis-lmwg commented 1 year ago

@ekluzek Starting with https://github.com/ESCOMP/SimpleLand/pull/46/commits/2c30b33363aacd0542a3e87081ba9863f0e6354c and over the course of a few commits, I removed the drydep code from my branch. I saw your conversation with Isla and hope that I don't need to bring drydep back...

ekluzek commented 1 year ago

I'm still pretty confident we don't need to bring drydep back. And if we do -- it won't be in it's current form -- it would be a prescribed mode. So it would just read data off the mml_surdat file and send it. But, I think this all will be done in the cesm2_3 branch and not in the cesm2_1 branch. So I don't see that you'll bring drydep back at all.

marysa commented 1 year ago

I agree with Erik - if we need it (looking into that is on my list for tomorrow!) we'd just grab the climatological flux from a coupled run, put it in the input file, and have SLIM pass it up to the atmosphere like we do now with dust.

slevis-lmwg commented 1 year ago

Most recent git ls-files | xargs wc -l gives 53288.

slevis-lmwg commented 1 year ago

New baselines: slim-n11_cesm2.1.4 New tag: slim0.1.007_release-cesm2.1.4