search

ESCOMP / SimpleLand

Simple Land Model for CESM --- *** IN DEVELOPMENT *** --- please contact for more info. See supplemental information of https://journals.ametsoc.org/doi/abs/10.1175/JCLI-D-18-0812.1 for a description of SLIM physics. Implementation of SLIM into the main CESM trunk is ongoing. SLIM currently works with the CESM2.1 release, but must be downloaded from this repository until we finish implementing it properly into the main CESM code.
Other
12 stars 7 forks source link

Update the MML_* history fields to remove the MML_ part #54

Closed ekluzek closed 1 year ago

ekluzek commented 1 year ago

After we have removed the CLM fields from SLIM, we should rework the MML* history fields to remove the MML part of the name. Possibly some of the names should be changed so they better reflect what is going on in SLIM.

ekluzek commented 1 year ago

As part of this we should make sure the fields are default active as they should be. That part is pretty high priority. Removing the MML_* part when it doesn't conflict with other code would also be really helpful for users.

slevis-lmwg commented 1 year ago

Once this is addressed, I will need to generate new baselines.

slevis-lmwg commented 1 year ago

Removing mml from all history field names and their long descriptions.

Follow-up questions: 1) Remove mml from variable names? 2) Remove mml from examples like this? call hist_addfld2d (fname='soilz', units='m', type2d='mml_lev', ..., mml_dim=mml_nsoi) I.e., from mml_lev, mml_dim, mml_nsoi?

I'm leaning against 1 and 2 above for now OR I would replace mml with slim. We may find it helpful to maintain a distinction from the bit of clm code that hasn't been removed, yet.

ekluzek commented 1 year ago

Hmmm good question. I suggest as a first step you just change the output history names and then run baselines and bring that in as one thing. That will establish that the name change doesn't change answers although it will appear so in the baselines.

After that is done you can then do the more extensive internal changes to change variable names and then ensure those changes are bit for bit with the baselines. So the internal changes can be ensured they are identical.