EZ-Robotics / EZ-Template

Simple plug-and-play PROS template that handles drive base functions for VEX robots.
https://ez-robotics.github.io/EZ-Template/
Mozilla Public License 2.0
75 stars 37 forks source link

🐛[BUG] - `pid_wait_until_index()` should wait until the point has passed #198

Open ssejrog opened 2 days ago

ssejrog commented 2 days ago

Expected Behavior

pid_wait_until_index() should wait until the point has passed

Actual Behavior

pid_wait_until_index() waits until the index point becomes the target, the robot will be sitting LOOK_AHEAD away from the index point when it exits.

Steps to Reproduce

chassis.pid_odom_set({{{0_in, 24_in}, fwd, 110},
                      {{12_in, 24_in}, rev, 110},
                      {{24_in, 24_in}, rev, 110}},
                     true);
chassis.pid_wait_until_index(1);  // Waits until the robot passes 12, 24
Intake.move(127);
chassis.pid_wait();

Versions

PROS Kernel Version: EZ-Template Version: Other Libraries: EZ-Template 3.2.0-beta.6 Kernel 4.1.1

OPTIONAL: Additional Information

A new function should be added, pid_wait_until_index_started(), that keeps the current behavior.

ssejrog commented 2 days ago

Seems like this issue doesn't actually exist. A new function should still be added that has the "original" behavior