search

EZ-Robotics / EZ-Template

Simple plug-and-play PROS template that handles drive base functions for VEX robots.
https://ez-robotics.github.io/EZ-Template/
Mozilla Public License 2.0
69 stars 27 forks source link

Every `_get()` should have a `_set()`, every `_set()` should have a `_get()` #73

Closed ssejrog closed 7 months ago

ssejrog commented 9 months ago

Functions that set do not always have a corresponding `get.

Here are a list of functions that are missing a get: opcontrol_curve_default_set() opcontrol_curve_default_get() <- needed opcontrol_curve_buttons_left_set() opcontrol_curve_buttons_left_get() <- needed opcontrol_curve_buttons_right_set() opcontrol_curve_buttons_right_get() <- needed opcontrol_drive_activebrake_set() opcontrol_drive_activebrake_get() <- needed drive_brake_set() drive_brake_get() <- needed drive_current_limit_set() drive_current_limit_set() <- needed pid_speed_max_set() pid_speed_max_get() <- needed pid_drive_constants_set() pid_drive_constants_get() <- needed pid_drive_forward_constants_set() pid_drive_forward_constants_get() <- needed pid_drive_backward_constants_set() pid_drive_backward_constants_get() <- needed pid_turn_constants_set() pid_turn_constants_get() <- needed pid_swing_constants_set() pid_swing_constants_get() <- needed pid_heading_constants_set() pid_heading_constants_get() <- needed name_set() name_get() <- needed

There are some functions that take multiple parameters that aren't setup to be structs. Should these have a corresponding get? The functions in question are: pid_drive_set() pid_turn_set() pid_swing_set() pid_turn_relative_set() pid_swing_relative_set() pid_drive_exit_condition_set() pid_turn_exit_condition_set() pid_swing_exit_condition_set() exit_condition_set()