EarthObservation / rvt-arcgis-pro

ArcGIS Pro Relief Visualization Toolbox Raster Functions
Apache License 2.0
7 stars 1 forks source link

Re-appearing issues with padding #6

Closed GDoerffel65 closed 1 year ago

GDoerffel65 commented 1 year ago

Hi Ziga's,

recently I discovered, that the padding issues we had talked about quite a while back are re-appearing. This happens, when you hand over large files to RVT that get treated in blocks by ArcGIS and each request returned from RVT will then be re-compiled to the larger image it comes from. Using the "padding" capability of the core raster functions, this usually will work (only boundary effects remaining, but no errors in the image, where it is tiled). This was solved in an earlier version. I assume you switched back to handle padding and tiling inside your code ... which now returns bad tiled results. Cant copy a screenshot here, as the previous posted python error does not allow me to run this right now. Feel free to contact me on this.

Cheers Guenter

zm8597 commented 1 year ago

Hey Geunter, Yes I wrote some hacky code to remove edge effect, because ArcGIS Pro alway padds image/tiles on edges with zeroes. Hacky code tries to detect edges (zeroes) and then it swaps them with numpy edge padding algorithm values. I will probably remove this part of code and go back to an edge effect, since it is causing issues on tiles. I need to consult with other Žiga 😄. Thank you for pointing this out.

GDoerffel65 commented 1 year ago

Hey Ziga,

The issue with this is: Pro SHOULD always request overlapping parts and then remove the outer parts itself … and the way you deal with it somehow breaks this. It USED to work a while ago … maybe we can look into this again 😊

Guenter Doerffel | Technology Evangelist Imagery & Raster Analytics, Europe

From: Žiga Maroh @.> Sent: Monday, January 9, 2023 6:16 PM To: EarthObservation/rvt-arcgis-pro @.> Cc: Guenter Doerffel @.>; Author @.> Subject: Re: [EarthObservation/rvt-arcgis-pro] Re-appearing issues with padding (Issue #6)

Hey Geunter, Yes I wrote some hacky code to remove edge effect, because ArcGIS Pro alway padds image/tiles on edges with zeroes. Hacky code tries to detect edges (zeroes) and then it swaps them with numpy edge padding algorithm values. I will probably remove this part of code and go back to an edge effect, since it is causing issues on tiles. I need to consult with other Žiga 😄. Thank you for pointing this out.

— Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/EarthObservation/rvt-arcgis-pro/issues/6*issuecomment-1375976341__;Iw!!CKZwjTOV!z9L7pJgLQNvnMztt-rE6ohNAFDEYehgMCZIA3au4L0Da-Y_J2sDMEA-yBM0kxY-tlbcVoUNPIfpf5miKWStHuyI$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AI6MLE3MNZUGYHOH4XC4QFDWRRBWTANCNFSM6AAAAAATQVVI6Y__;!!CKZwjTOV!z9L7pJgLQNvnMztt-rE6ohNAFDEYehgMCZIA3au4L0Da-Y_J2sDMEA-yBM0kxY-tlbcVoUNPIfpf5miK4JcSyNY$. You are receiving this because you authored the thread.Message ID: @.***>

GDoerffel65 commented 1 year ago

Ziga: On the strange python library issue: Might have been my bad (some corrupted file). I ran into another very strange issue, figured this was an installation problem, re-installled python and now RVT works as it always did. Sorry for that part

G.

Guenter Doerffel | Technology Evangelist Imagery & Raster Analytics, Europe

From: Žiga Maroh @.> Sent: Monday, January 9, 2023 6:16 PM To: EarthObservation/rvt-arcgis-pro @.> Cc: Guenter Doerffel @.>; Author @.> Subject: Re: [EarthObservation/rvt-arcgis-pro] Re-appearing issues with padding (Issue #6)

Hey Geunter, Yes I wrote some hacky code to remove edge effect, because ArcGIS Pro alway padds image/tiles on edges with zeroes. Hacky code tries to detect edges (zeroes) and then it swaps them with numpy edge padding algorithm values. I will probably remove this part of code and go back to an edge effect, since it is causing issues on tiles. I need to consult with other Žiga 😄. Thank you for pointing this out.

— Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/EarthObservation/rvt-arcgis-pro/issues/6*issuecomment-1375976341__;Iw!!CKZwjTOV!z9L7pJgLQNvnMztt-rE6ohNAFDEYehgMCZIA3au4L0Da-Y_J2sDMEA-yBM0kxY-tlbcVoUNPIfpf5miKWStHuyI$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AI6MLE3MNZUGYHOH4XC4QFDWRRBWTANCNFSM6AAAAAATQVVI6Y__;!!CKZwjTOV!z9L7pJgLQNvnMztt-rE6ohNAFDEYehgMCZIA3au4L0Da-Y_J2sDMEA-yBM0kxY-tlbcVoUNPIfpf5miK4JcSyNY$. You are receiving this because you authored the thread.Message ID: @.***>