Revamp - Githubissues

EasyRPG / Tools

Assorted tools to handle RPG Maker 2000/2003 files

https://easyrpg.org/tools/

49 stars 18 forks source link

Revamp #88

Closed carstene1ns closed 2 months ago

carstene1ns commented 2 months ago

This should fix all distribution tarballs, the cmakery was not present anywhere.
This updates all version numbers by one minor version to generate new archives.
The config.h autotools feature was nowhere used, so has been removed and cmake provides the same strings now. The cmake configuration has therefore been updated.
The external dir provides shipped libraries and is symlinked to each source folder, which will be replaced by a copy in distribution tarballs
The zopfli and dirent_win libraries have been updated
An argument parser was added to some tools to make building help pages and validating input easier

carstene1ns commented 2 months ago

Seems like older macos has bad c++17 support. We would need to bump deployment target from 10.9 to 10.13 (High Sierra) or I could try to disable the conversion functions on macos, I think we only need them in the depth argument to lcfviz...

Ghabry commented 2 months ago

Can you add a remark the README somewhere that on Windows the following command must be executed once: git config --global core.symlinks true (then delete the repo and clone again).

On the Server I also had to configure a group policy to permit symlinks for users but this restriction is lifted since recent Windows 10 versions and Windows 11, so only affects Windows Server users.

EDIT: Windows 11 requires dev mode to be enabled for them to work:

grafik

I'm also getting a linker error in gencache now because it uses the dynamic CRT I currently investigate this...

Bumping to Mac 10.13 is fine imo. Is from 2017 :D

Ghabry commented 2 months ago

Thanks for reworking this and getting rid of the ugly manual arg parsing. And :+1: for moving the lmu2png function args into a struct.

The linker error seems to go away when using the "ConfigureWindows.cmake" file we use in Player. The one we use in the Tools currently is outdated. (but I cannot explain why it worked before and do not want to invest time to figure it out ^^)