Ecks1337 / RyuSAK

GNU General Public License v3.0
1.22k stars 78 forks source link

Fulfill license obligation #54

Closed SilverSteven closed 1 year ago

SilverSteven commented 1 year ago

Missing notice for modifications on original work (violation of GPL-3.0)

[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license GPL-3.0 dictates. Your project is a forking project from CapitaineJSparrow/emusak-ui which adopts GPL-3.0 as its project license. The modification terms and conditions of GPL-3.0 dictate that:

GPL-3.0:

... The work must carry prominent notices stating that you modified it, and giving a relevant date. ...

Therefore, I think the project is obligated to abide by the modification terms and conditions in GPL-3.0.

[Violation of modification terms and conditions] I run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices. You have 25 commits which conduct modifications to the original work, all of which are not declared in README.md. Specifically, of the 25 commits, 25 commits are not announced in the file. According to the license terms and conditions above, it is regarded as license violation. Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 25 commits.

[Fix] For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.

Full details of the report you could refer to the html file attached. Hope it helps!

Cheers!