search

Election-Tech-Initiative / electionguard-cpp

A C++ implementation of ElectionGuard specification focused on encryption components.
https://www.electionguard.vote/
MIT License
23 stars 26 forks source link

C# use IDisposable to avoid unnecessary copies #164

Open AddressXception opened 3 years ago

AddressXception commented 3 years ago

Feature Request

Description In a few places, there are unnecessary copy operations when moving between managed and unmanaged blocks of memory. For instance:

This request is to refactor the managed code to expose the unmanaged objects directly where necessary by pinning the memory and bypassing the garbage collector. IDisposable should be used on the managed side to call the unmanaged "_free" functions when necessary. Careful consideration must be given to ownership as not every contiguous block of memory returned to managed code is actually owned by the caller.

The implemented pattern should be consistently applied throughout the C# binding layer.

gagandeepp commented 3 years ago

intersted please assign

keithrfung commented 3 years ago

@gagandeepp Have at it.

gagandeepp commented 3 years ago

@AddressXception I was able to setup dev environment of this repo. Do I need to make changes in ElectionGuard.Encryption/Group.cs? Let me know when we can connect on this ?? @keithrfung I am having some doubts related to this issue