Fix Build warning C4068 for MSVC

Election-Tech-Initiative / electionguard-cpp

A C++ implementation of ElectionGuard specification focused on encryption components.

https://www.electionguard.vote/

MIT License

23 stars 26 forks source link

Closed avinal closed 2 years ago

avinal commented 2 years ago

Signed-off-by: Avinal Kumar avinal.xlvii@gmail.com

Link your PR to an issue

Fixes #216

GCC pragma is not a valid pragma in MSVC, thus produces warning C4068: unknown pragma 'GCC'.
The workaround is to encapsulate the GCC pragma in if GNUC defined block.

Describe the best way to test or validate your PR.

keithrfung commented 2 years ago

@avinal One of the builds failed. Take a look.

avinal commented 2 years ago

Hey @keithrfung, mistakenly I wrapped the whole pragma into if directive, I have fixed it now.

avinal commented 2 years ago

Finally 😅 its complete

keithrfung commented 2 years ago

@avinal I know right? It's a long build. hahaha.

avinal commented 2 years ago

@avinal I know right? It's a long build. hahaha.

Very long🥲, and for 4 line change it felt like a lifetime 😂.