search

Election-Tech-Initiative / electionguard-cpp

A C++ implementation of ElectionGuard specification focused on encryption components.
https://www.electionguard.vote/
MIT License
23 stars 26 forks source link

Updated doc test version #314

Closed MatthewRatzell closed 2 years ago

MatthewRatzell commented 2 years ago

Description

Updated the doctest git tag because I was getting a file missing error when running make tests, it seems like doctest removed doctest.h from 2.4.8 when they released 2.4.9. Updating the tag gave me the file needed

Testing

Describe the best way to test or validate your PR.

lprichar commented 2 years ago

@MatthewRatzell I believe this failed because of a change on the build server that's been fixed in main. I tried rerunning, but I'm pretty sure it will fail again. If so please merge from main or rebase and push and it should pass.

MatthewRatzell commented 2 years ago

should be good to go now, Ill check back later and make sure it passes

MatthewRatzell commented 2 years ago

I updated one other dependency whose tag seemed outdated. I'm now able to run the make commands so I can build and test on my end with these changes