Election-Tech-Initiative / electionguard-cpp

A C++ implementation of ElectionGuard specification focused on encryption components.
https://www.electionguard.vote/
MIT License
23 stars 26 forks source link

Make environment fails on debian during unzipping of sample-data.zip #320

Closed awaistanveer closed 2 years ago

awaistanveer commented 2 years ago

Is there an existing issue for this?

Current Behavior

make environment fails after installing the required packages on Debian (It will also fail on other Linux distributions as well). I get the following error message:

unzip -o sample-data.zip
unzip:  cannot find or open sample-data.zip, sample-data.zip.zip or sample-data.zip.ZIP.
make: *** [Makefile:62: environment] Error 9

This is coming from the following line since it tries to unzip a non-existent file because sample-data.zip is saved as sample-data-container.zip by wget command in the previous lines:

https://github.com/microsoft/electionguard-cpp/blob/9e8f3b235f5532aa688ef5ed2023f95a47c1c267/Makefile#L68

Expected Behavior

make environment should succeed.

Steps To Reproduce

  1. Debian Gnu/Linux 11 (although this bug will affect other Linux distributions as well.)
  2. Clone the repository
  3. run make environment

Environment

- OS: Debian Gnu/Linux 11

Anything else?

No response