Fix "lazy" formatting in logging functions

Electrostatics / pdb2pqr

PDB2PQR - determining titration states, adding missing atoms, and assigning charges/radii to biomolecules.

http://www.poissonboltzmann.org/

Other

124 stars 34 forks source link

Fix "lazy" formatting in logging functions #222

Open intendo opened 3 years ago

intendo commented 3 years ago

We were too eager to implement fstrings and went too far. The correct way to implement strings in logging functions is to use the lazy % formatting.

sobolevnrm commented 3 years ago

I think that is mainly for performance reasons, right? The f-strings get evaluated even if the logging level is below the basicConfig setting? If we're not seeing major performance problems, then this should be pretty low priority...

intendo commented 3 years ago

This is so low, I will only work on it while watching TV while holding a sleeping puppy :-)