Closed sobolevnrm closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
5e8e7fb
) 65.39% compared to head (965b0bf
) 65.39%.:exclamation: Current head 965b0bf differs from pull request most recent head 77cfdea. Consider uploading reports for the commit 77cfdea to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I don't remember if you're using SemVer for pdb2pqr. If yes, then you should probably maintain the pdb2pqr30 executable until a 4.0 release because any workflow scripts that upgrade will break. Perhaps just maintain both scripts in parallel and deprecate the pdb2pqr30 one?
Otherwise looks fine.
(Given that I am not clear about how versions are handled, I am not feeling confident to approve or request changes and will just comment.)
EDIT: I pressed the wrong button and "approved" instead of "commented" but should be fine as I don't have write access. So read it as "approve with caution".
Thanks! The new 77cfdea5e2120a168f02ed1d05f88229524a3743 should address this.
Updates binary name.
Fixes #335.