search

ElementsProject / libwally-core

Useful primitives for wallets
Other
282 stars 135 forks source link

Sighash support for BIP341/342/118 #356

Closed instagibbs closed 1 year ago

instagibbs commented 1 year ago

This has received some light testing as part of my work on eltoo in CLN. Should be very simple to add the actual signature support on top, which I've done in my local CLN repo in a few lines.

Partially resolves https://github.com/ElementsProject/libwally-core/issues/304

cc @greenaddress

jgriffiths commented 1 year ago

Hi @instagibbs thanks for this!

Will need a little tweaking for merging, I've merged the first commit to https://github.com/ElementsProject/libwally-core/pull/351 and will work on the others as time permits. Leaving this open to track.

instagibbs commented 1 year ago

Good stuff, let me know whatever is needed

jgriffiths commented 1 year ago

@instagibbs as discussed offline, I've pushed the reworked commits to https://github.com/ElementsProject/libwally-core/pull/351 if you'd like to review there (or offline). Thanks!