search

ElementsProject / libwally-core

Useful primitives for wallets
Other
282 stars 135 forks source link

implement psbt_v0_to_v2 #362

Closed instagibbs closed 1 year ago

instagibbs commented 1 year ago

Not tested. Needed for CLN upstream since our plan is to handle all PSBTs internally as V2, then export as V0 as required.

instagibbs commented 1 year ago

@achow101 would appreciate an eyeball to see if this is on the right track

instagibbs commented 1 year ago

I think that's unneeded as per "psbt_set_global_tx" which sets those. Waiting on a set of test round trip vectors from jon before continuing :+1:

jgriffiths commented 1 year ago

@instagibbs see https://github.com/ElementsProject/libwally-core/commit/8af7892ad069acfb77dfb9ed2119643dc83b9ca1 for an example test

instagibbs commented 1 year ago

Wrote up some more tests in https://github.com/instagibbs/libwally-core/commit/05ec12c1cf36f18307610ce45202dabddd826c81

@jgriffiths I can push a fix for the global tx issue and more tests in this PR if you like?

instagibbs commented 1 year ago

closing as #364 implemented all changes