ElementsProject / libwally-core

Useful primitives for wallets
Other
282 stars 135 forks source link

Descriptor updates #402

Closed jgriffiths closed 1 year ago

jgriffiths commented 1 year ago

Add support for generation of wrappers with value expressions. Verify that adding this support does not expose a recent vulnerability affecting Ledger in this case. Also add support for raw() to generate empty scripts.

Note that the test cases here expose what appear to be issues in either the spec or core implementation. Until such time as the spec is confirmed incorrect, the behaviour of the wally impl is expected to/tested to follow it.

cc: @k-matsuzawa @JamieDriver

JamieDriver commented 1 year ago

Did a bit of testing with 'a:1' expression and seems good.
eyeballed code, can't see anything glaring, although not very familiar with this area. ack 5220c20