search

ElementsProject / libwally-core

Useful primitives for wallets
Other
284 stars 136 forks source link

psbt: don't serialize witness data for input non-witness utxos #452

Closed jgriffiths closed 4 months ago

jgriffiths commented 4 months ago

Some test vectors in BIP 0174 are incorrect - they include witness data in non-witness UTXOs, which is not output (at least now) by core.

Accept witness data if provided, but do not output it. This matches cores behaviour as can be seen by running utxoupdatepsbt on the test samples that have been fixed here. We keep some old test cases from the BIP to prove wallys re-serialization matches core.

JamieDriver commented 4 months ago

I agree from my own testing w/ core that 'p2wpkh' and 'p2sh-p2wpkh' inputs have both witness_utxo and non_witness_utxo sections, whereas 'p2pkh' inputs only have a non_witness_utxo section.

I agree also that non_witness_utxo sections do not themselves contain txinwitness data.

On this basis, utack 1eb727c