search

Elenterius / Biomancy

Biomancy is magi-tech Mod for Minecraft. The mod is inspired by Biopunk and Bio-Manipulation and features a fleshy art style.
https://modrinth.com/mod/biomancy
Other
41 stars 25 forks source link

[Suggestion] Human-readable data files #119

Closed MarioSMB closed 5 months ago

MarioSMB commented 8 months ago

Please complete the following information:

Describe the bug As a modpack creator it is difficult to extend upon the data files (recipes, tags, loot tables etc) as they are all formatted as a single line, e.g.
{"type":"biomancy:despoil","conditions":[{"condition":"minecraft:entity_properties","entity":"this","predicate":{"flags":{"is_baby":false}}},{"condition":"minecraft:killed_by_player"}],"weights":{"biomancy_mob_claw":150,"biomancy_mob_fang":140,"biomancy_mob_gland":40,"biomancy_mob_marrow":45,"biomancy_mob_sinew":70,"biomancy_toxin_gland":75,"biomancy_volatile_gland":50,"biomancy_withered_mob_marrow":65}}

Expected behavior It would make life much easier for those who wish to support this mod to split each parameter to its own line like Mojang's data files, thanks.

Additional context

Elenterius commented 8 months ago

Sorry, but the json files in the mod jar will always be minified. You can easily pretty format json files with any capable text editor.

But.. Soon I will no longer gitinore the generated json resouces and you will be able to find pretty formatted jsons here on github (at the beginning only in the mc1.20.1/dev branch)

MarioSMB commented 8 months ago

Glad to hear there will be some way to get the expanded versions, though I do hope you can consider expanding the files in the mod itself in the future as the formatting differences make it a challenge to extend cross-mod tag/recipe compatibility.

Elenterius commented 8 months ago

They are now available https://github.com/Elenterius/Biomancy/tree/mc1.20.1/dev/src/generated/resources (the main branch mc1.20.1/prod will have them when a release happens)