search

EllaSoderberg / EmotionandLiking

A study built for the course DA2210 at KTH
0 stars 3 forks source link

Artistic education #5

Open EllaSoderberg opened 4 years ago

EllaSoderberg commented 4 years ago

In the demography form, there should be a question for artistic education. Should it be input or choice?

kristinlilja commented 4 years ago

I made it into choices so every input are the same.

kristinlilja commented 4 years ago

JK we cannot merge my version

Geoodees commented 4 years ago

Should be one for arts and one for music. It should be choice. The choices will be the same as highest level of education. @kristinlilja check with me and I'll help you with merging.

EllaSoderberg commented 4 years ago

This is what Ana wrote:

They should be choice questions with same answers as the current education Namely, please, remove what now is the last question and insert the following two instead: What is the highest degree of formal education in music that you have ever attained? What is the highest degree of formal education in visual art, architecture, or design that you have ever attained? For both these and the question on general education, the allowed responses should be the following: None Primary Secondary Bachelor Masters Doctorate

kristinlilja commented 4 years ago

I can fix this later today and then make a PR. Have to finish the peer review first.

mån 28 sep. 2020 kl. 11:48 skrev Ella Söderberg notifications@github.com:

This is what Ana wrote:

They should be choice questions with same answers as the current education

Namely, please, remove what now is the last question and insert the following two instead:

What is the highest degree of formal education in music that you have ever attained?

What is the highest degree of formal education in visual art, architecture, or design that you have ever attained?

For both these and the question on general education, the allowed responses should be the following:

None

Primary

Secondary

Bachelor

Masters

Doctorate

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EllaSoderberg/EmotionandLiking/issues/5#issuecomment-699902583, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARBRZPGC5ZDR5Y2EME4PGYTSIBLWVANCNFSM4RZLT22A .

EllaSoderberg commented 4 years ago

Of course, awesome and thank you!! :))

kristinlilja commented 4 years ago

Done see PR