search

EmilyOng / Scratch.activity

A Scratch Activity for Sugarizer, integrated from https://github.com/LLK/scratch-gui
6 stars 6 forks source link

Display error on recent version of Windows 10/EDGE #3

Open llaske opened 6 years ago

llaske commented 6 years ago

I'm working on final testing of Sugarizer v1.0. Unfortunately I've got an issue with your Sugarizer encapsulation of Scratch. It seems that it don't works on recent version of Windows 10/EDGE. Most of the content is blank:

image

I've tested it few month ago and it perfectly worked but I guess something changed in the browser so the compatibility is broken now. I've seen that recent version of Scratch v3 works on Windows 10/EDGE. So I would like to upgrade your encapsulation but I'm not familiar with the process describe in the README. Could you help me on this? First, what's the command line to convert .jsx to .js? Did you use Grunt?

EmilyOng commented 6 years ago

Sure, I used the babeljs converter.

On Fri, 13 Apr 2018 at 05:33, Lionel LASKE notifications@github.com wrote:

I'm working on final testing of Sugarizer v1.0. Unfortunately I've got an issue with your Sugarizer encapsulation of Scratch. It seems that it don't works on recent version of Windows 10/EDGE. Most of the content is blank:

[image: image] https://user-images.githubusercontent.com/981841/38705417-cd0d32ee-3ea9-11e8-81ab-643fa40f07f1.png

I've tested it few month ago and it perfectly worked but I guess something changed in the browser so the compatibility is broken now. I've seen that recent version of Scratch v3 https://github.com/LLK/scratch-gui works on Windows 10/EDGE. So I would like to upgrade your encapsulation but I'm not familiar with the process describe in the README. Could you help me on this? First, what's the command line to convert .jsx to .js? Did you use Grunt?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EmilyOng/Scratch.activity/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AUN_KYcQoIJa4XFVvc8qhMT_w3o7UfMUks5tn8gTgaJpZM4TShvn .

llaske commented 6 years ago

Could you share the script you've used to convert the whole Scratch project?

EmilyOng commented 6 years ago

I havent found a very effective way to convert all at once. I can convert the latest scratch repository and send it to you by tonight?

On Sat, 14 Apr 2018 at 03:49, Lionel LASKE notifications@github.com wrote:

Could you share the script you've used to convert the whole Scratch project?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/EmilyOng/Scratch.activity/issues/3#issuecomment-381243520, or mute the thread https://github.com/notifications/unsubscribe-auth/AUN_KZvaClAlHvrOfeaf0T3GFu6obtmMks5toQFPgaJpZM4TShvn .

llaske commented 6 years ago

We'll be great. Thanks.

EmilyOng commented 6 years ago

I’m sorry it might take awhile but I will try to complete it soon because I am having my exams now.

On Sat, 14 Apr 2018 at 16:54, Lionel LASKE notifications@github.com wrote:

We'll be great. Thanks.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/EmilyOng/Scratch.activity/issues/3#issuecomment-381314600, or mute the thread https://github.com/notifications/unsubscribe-auth/AUN_KU4o2fTDf_W3YK5WVDGwQFCUJQYpks5tobkwgaJpZM4TShvn .

llaske commented 6 years ago

Hi Emily, I've finally managed to fix the issue myself. But it was complex because lot of code changed in Scratch v3 since your work. More specifically, all the logic to save the project has been totally reviewed using Promise. I've published my change here and here.