Merge stuff from what I have in launchpad branch

EmperorArthur / VBA-M

The VBA-M project at http://vba-m.com/ is rarely updated. This is a version that will run without requiring old, unsupported libraries. Please treat it as a testing branch before (some) of the changes filter into the main code base.

Other

8 stars 2 forks source link

Merge stuff from what I have in launchpad branch #8

Closed sergiobenrocha2 closed 9 years ago

sergiobenrocha2 commented 9 years ago

Please, don't delete icons... they are optimized for each size (you can't use only one big svg icon for all icons sizes!). And I waste a lot of time to re-make them :( There are some changes in the debian packaging too.

sergiobenrocha2 commented 9 years ago

It seems debian package is broken, after all changes. I'll see this later.

sergiobenrocha2 commented 9 years ago

I'm getting

-- Installing: /home/sergio/Projects/VBA-M/vbam-emperor_fork-git-sergio/debian/tmp/usr/share/icons/hicolor/scalable/apps/vbam.svg/vbam.svg
CMake Error at src/gtk/cmake_install.cmake:36 (FILE):
  file INSTALL cannot find
  "/home/sergio/Projects/VBA-M/vbam-emperor_fork-git-sergio/builddir/src/gtk/gvbam".
Call Stack (most recent call first):
  cmake_install.cmake:61 (INCLUDE)

make[1]: *** [install] Error 1

3 errors: first, you have an weird apps/vbam.svg/vbam.svg path, the vbam.svg is inside usr/share/icons/hicolor/scalable/apps/ second, it's missing the others png icons (16x16/apps/vbam.png, 32x32...) third, make command from rules are trying to get gvbam from the wrong place, it seems now it appears in builddir/, instead of builddir/src/gtk/

sergiobenrocha2 commented 9 years ago

About the icons, take a look why you can't resize one icon to other size:

http://www.zimagez.com/galerie/Same-size--but-one-weird-32609-0.php

the first icon is the 48 px I think, resized to 128
and the second, is the 128 optimized icon

EmperorArthur commented 9 years ago

Manually fixed the icon issue in master. I've also gone ahead and added a script to regenerate all the icons from the svg files in src.

EmperorArthur commented 9 years ago

I've cherry-picked all the non icon commits. Thanks for the help.

sergiobenrocha2 commented 9 years ago

why the icons have the 128x128.png name, for example? (in hicolor/128x128/apps/)

They should call vbam.png

EmperorArthur commented 9 years ago

Scripting error, and proof of why I should double check things when coding at 4am. Fixed.