search

Empirical-org-Archive / Quill-Grammar

Quill Grammar App
http://grammar.quill.org/
GNU Affero General Public License v3.0
11 stars 12 forks source link

Use Rule Number for Rule ID #12

Closed wlaurance closed 9 years ago

wlaurance commented 9 years ago

Since we are keeping track of rule numbers, it will be easy to make this the id number used to identify the object in the rules list.

Right now, the current look up function will work, because the id is equal to the rule number. Once more rules are added to the system, this will not be the case and things will break.

wlaurance commented 9 years ago

Now that we are using uid's instead of the number, we will need to create and setup an index for uid to rule numbers.

wlaurance commented 9 years ago

If any new rules are created through the /cms route, they will not work.

petergault commented 9 years ago

This is no longer an issue, correct? We can use integer IDs for the rules and be ok?

wlaurance commented 9 years ago

Yes,

We will move to a pure integer based id and not the firebase uid scheme. ᐧ

On Sat, Jul 18, 2015 at 11:13 AM, Peter Gault notifications@github.com wrote:

This is no longer an issue, correct? We can use integer IDs for the rules and be ok?

— Reply to this email directly or view it on GitHub https://github.com/empirical-org/Quill-Grammar/issues/12#issuecomment-122573785 .