search

EnEff-BIM / EnEffBIM-Framework

translating from BIM to BEPS
MIT License
8 stars 0 forks source link

Templating engine #11

Closed thorade closed 9 years ago

thorade commented 9 years ago

There are various template engines available for Python: https://wiki.python.org/moin/Templating Currently MoCGF uses Mako. Switching to a different template engine is still possible, but we should make that decision soon.

thorade commented 9 years ago

I think I ran into this bug: https://bitbucket.org/zzzeek/mako/issue/150/line-ending-handling-broken-on-win32 It is open since September 2010

jraedler commented 9 years ago

Looks like this can be fixed by changing

 def read_file(path, mode='rb'):

to

 def read_file(path, mode='r'):

in Makos util.py. We can use rU for compatibility with python 2.7. If we are able to validate this change we might send a patch to the Mako author.

thorade commented 9 years ago

As discussed after the workshop: @jraedler will investigate how difficult it is to have both engines available and choose one from the .ini file.

thorade commented 9 years ago

It would be nice to have the CR-CR-LF bug fixed upstream in Mako: https://bitbucket.org/zzzeek/mako/issue/150/line-ending-handling-broken-on-win32 What would we have to test before submitting a Pull Request?