EnEff-BIM / EnEffBIM-Framework

translating from BIM to BEPS
MIT License
8 stars 0 forks source link

Initial values should not be part of Mapping Rule #127

Open PRemmen opened 8 years ago

PRemmen commented 8 years ago

The initial values (e.g. for volume inside a boiler) should not be part of the mapping rules, or should at least be handled with a different class then regular Property.

Example: ID0112

thorade commented 8 years ago

I could not find that ID. Did you mean ID1120? The boiler has ID879.

PRemmen commented 8 years ago

You can find the Property in the MappingRUle xml-file from AixLib

 <!-- property mapping for the hot water boiler -->
  <!-- Initialize properties: T.start, T.fixed -->
  <Property_Map_Gap RefId="ID0112">
    <Description>Initialization: temperature inside the CV in K</Description>
    <TargetPropertyName>T</TargetPropertyName>
      <TargetLocation>volume</TargetLocation>
    <DefaultValueNumber>328.15</DefaultValueNumber>
  </Property_Map_Gap>
thorade commented 8 years ago

OK, so I was looking at the wrong file...

ReinhardWimmer commented 8 years ago

I've just put the inital value into a comment in the mapping xml. Shall I also do that with the other initial values? If so, then someone needs to tell me which are the initial values. The use cases have changed and do not allign with the mapping rules anymore, so that I am not able to see which are the inital values. I could just search for the terms, like start, initialization, ...!?!