Capitalization of enum values causes wrong mapping generation

Encryqed / Dumper-7

Unreal Engine SDK Generator

756 stars 192 forks source link

Capitalization of enum values causes wrong mapping generation #139

Open adainrivers opened 5 months ago

adainrivers commented 5 months ago

https://github.com/Encryqed/Dumper-7/blob/edbd0bf06bec1163859375ad2d07426913b1ae74/Dumper/UnrealTypes.cpp#L39C7-L42C3

Because of this transformation, the enum names from the mapping sometimes doesn't match the actual values, making it harder to work with typed languages.

Fischsalat commented 5 months ago

Ah fuck. Well, I needed to remakethe IsValidName function anyways, to support characters from other languages. I guess this will just be one more thing to consider.

Fischsalat commented 3 months ago

Actually try the Unicode-Names branch. There's no forced capitalization of names on there at the moment.

Keep the issue open tho.