search

Erwin6997 / baby-names-react

Baby Name
https://cyf-erwin6997-baby-names.netlify.app/
0 stars 0 forks source link

Active gender button doesn't appear active #6

Closed frosas closed 4 years ago

frosas commented 4 years ago

According to the exercise,

The buttons should operate as "radio" buttons - exactly one should be active at any time.

The app should make it clear which filter is in effect.

Something as subtle as in the exercise example would do:

level-4

Erwin6997 commented 4 years ago

ok. I will change it

frosas commented 4 years ago

Closing this issue as it works as expected now.

Note though you could also have changed the (CSS) style of the images you had before when they were selected (by adding them a border, for example) instead of replacing them with an <input type="radio">

frosas commented 4 years ago

By the way, you forgot to select the initially selected radio button ("All") when the page loads