search

EventideSystems / tool_for_systemic_change

GNU Affero General Public License v3.0
6 stars 0 forks source link

Deleting components... error or Stop message #110

Closed emily-humphreys closed 8 years ago

emily-humphreys commented 9 years ago

Need some way to resolve Deletion of components that make up scorecard. For example: Deleting Organisations - this will affect Initiatives Should we put a warning or not allow this? Open to thoughts here?

ferrisoxide commented 9 years ago

Deleting Organisations won't affect Initiatives as such, as data is recorded per Initiative, not per Organisation. Can we confirm that this is the case? @emily-humphreys or @shaziv

But yes, I need to put traps in to prevent data from being broken (e.g. deleting a Community if it has already been assigned to a Scorecard).

emily-humphreys commented 9 years ago

Correct

On Sunday, October 18, 2015, Tom Tuddenham notifications@github.com wrote:

Deleting Organisations won't affect Initiatives as such, as data is recorded per Initiative, not per Organisation. Can we confirm that this is the case? @emily-humphreys https://github.com/emily-humphreys or @shaziv https://github.com/shaziv

But yes, I need to put traps in to prevent data from being broken (e.g. deleting a Community if it has already been assigned to a Scorecard).

— Reply to this email directly or view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/110#issuecomment-148986670 .

ferrisoxide commented 9 years ago

Need a review of all models / associations and ensure guards are in place to prevent orphaned data.

ferrisoxide commented 8 years ago

acts_as_paranoid - or rather its modern equivalent paranoia - is in place to prevent any deletion of records. All records are simply shuffled off into a deleted scope and unavailable in the main app (though they will appear marked as [DELETED] in activity logs.

ferrisoxide commented 8 years ago

Fundamentally this has been resolved in #181, though the UI is not as yet responding to 403 errors. This should be addressed by resolving #179