Update to Report: Addition to Transition Card Activity Report

[emily-humphreys]

See attached example report See new column and time stamp transition_card_activity_update.xlsx

[ferrisoxide]

@emily-humphreys

Estimate is $300+GST.

[emily-humphreys]

As per ticket #507 this will be informed by those requirements

On Wed, Dec 9, 2020 at 6:34 PM Tom Tuddenham notifications@github.com wrote:

@emily-humphreys https://github.com/emily-humphreys

Estimate is $300+GST.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/461#issuecomment-741604842, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOVW4XDU22FKHPCZ7R3ST4VQLANCNFSM4OM5UPOQ .

[ferrisoxide]

Add testing $60 + GST

[emily-humphreys]

Great :)

On Wed, Jan 20, 2021 at 12:41 PM Tom Tuddenham notifications@github.com wrote:

Add testing $60 + GST

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/461#issuecomment-763278425, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOWOPGSVEH7N7LEDEGTS2Y3TRANCNFSM4OM5UPOQ .

[ferrisoxide]

@emily-humphreys

1. Total counts vs number of checklist items updated

Just after some clarification here, is the initiative comment counts a measure of many times a comment has been added or changed, or simply a measure of whether a comment has been entered regardless of how many times it's updated?

For instance, in the same month Sam add a comment to a checklist item and then later updates the same comment. She doesn't update any other comments in her transition card.

When she runs the report for the month, will Sam see the Initiative comment updates value as 1, or as 2?

2. Per characteristic data

On a related note, you haven't added any example data on the characteristic rows. Should I assume you want to have the number of comments updated per characteristic on the rest of the report? E.g. If Sam from above had changed the comments for the 'Highlight the need to organise communities differently' checklist item in an initiative, then the tally (across all initiatives in the transition card) would appear on that row under the Initiative comment updates column:

Is that what you are after?

[ferrisoxide]

@emily-humphreys

Re 1 above, is it actually a measure of the number of checklist items have been updated per initiative?

E.g. if Sam has updated the 'Highlight the need to organise communities differently' comment on two different initiatives within the reporting period, then that would appear a '2' in the total (as well as a 2 on the actual characteristic row), regardless of how many times the comments were modifed?

That actually makes more sense, now I've said it out loud, but just wanted to check.

[ferrisoxide]

@emily-humphreys

As an example, this file was generated after updating 5 comments (i.e. 5 checklist items across different initiatives) - with some comments updated more than once within the reporting period

transition_card_activity.xlsx

[emily-humphreys]

Yes you've got it:

The number of updates to comments per initiative characteristic across all initiatives between the dates set.

However, as I'm writing this I realize it is deeply connected to #507. New Comments are what we want to track (as these represent changes to the 'how' a characterish is being addressed), not an edit to existing.

But perhaps we can park this and come back to it? Or is best we do the two together?

Happy to chat about this on the phone and realise that this is a much bigger piece of work. 😥

On Tue, Jan 26, 2021 at 4:36 PM Tom Tuddenham notifications@github.com wrote:

@emily-humphreys https://github.com/emily-humphreys

As an example, this file was generated after updating 5 comments (i.e. 5 checklist items across different initiatives) - with some comments updated more than once within the reporting period

transition_card_activity.xlsx https://github.com/ferrisoxide/wicked_software/files/5871470/transition_card_activity.xlsx

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/461#issuecomment-767318110, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOVNJ5KPAA3SK2RFMEDS3ZLWDANCNFSM4OM5UPOQ .

[ferrisoxide]

@emily-humphreys Ah, yep. I've actually coded this up - and I only thought about #507 while getting towards the end.

One thing that is emerging from this is the need for what is known as a CQRS style data model.

The nutshell, from your POV is that we should be identifying and tracking important "events" - e.g. first time a comment is made against a checklist item.

I've only spent a couple of hours on this ticket, and none of that is wasted time. But it might be worth having a quick chat about how we want to go about cataloguing events and other things in the application's problem domain - at least before tackling #507.

None of this is scary stuff BTW. It's kind of what I've been doing in my head, but it'd be good to get it out on paper (as it were). I'm available this evening (Friday) or any time over the weekend if you want to have a quick catch up.

[emily-humphreys]

Okay great - let’s chat in the AM tomorrow as Friday night is madness in our house

On Fri, 29 Jan 2021 at 11:33 am, Tom Tuddenham notifications@github.com wrote:

@emily-humphreys https://github.com/emily-humphreys Ah, yep. I've actually coded this up - and I only thought about #507 https://github.com/ferrisoxide/wicked_software/issues/507 while getting towards the end.

One thing that is emerging from this is the need for what is known as a CQRS https://www.martinfowler.com/bliki/CQRS.html style data model.

The nutshell, from your POV is that we should be identifying and tracking important "events" - e.g. first time a comment is made against a checklist item.

I've only spent a couple of hours on this ticket, and none of that is wasted time. But it might be worth having a quick chat about how we want to go about cataloguing events and other things in the application's problem domain - at least before tackling #507 https://github.com/ferrisoxide/wicked_software/issues/507.

None of this is scary stuff BTW. It's kind of what I've been doing in my head, but it'd be good to get it out on paper (as it were). I'm available this evening (Friday) or any time over the weekend if you want to have a quick catch up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/461#issuecomment-769501065, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOWT6EEGCYSTKIEOFW3S4ICORANCNFSM4OM5UPOQ .

[ferrisoxide]

👍 @emily-humphreys

[ferrisoxide]

DEV NOTE

Useful SQL:

select characteristic_id, count(distinct(checklist_items.*)) as count  from checklist_items 
inner join versions 
  on versions.item_id = checklist_items.id 
  AND versions.item_type = 'ChecklistItem'
inner join initiatives on initiatives.id = checklist_items.initiative_id
where
  checklist_items.comment IS NOT NULL and checklist_items.comment <> ''
  AND versions.event = 'update'
  AND TRIM(substring(versions.object from 'comment\:\s(.*)\ncharacteristic_id')) <> checklist_items.comment
group by characteristic_id

[emily-humphreys]

Hi Tom, can we chat about this when you have a moment. New column should be 'Initiative comment update' - not New comments.

I think we need to talk through this as I'm worried we have crossed wires. Whens a good time for you?

[ferrisoxide]

@emily-humphreys

It's ok, I get where I went wrong. Don't know where my head is at. Will fix this over the weekend.

Initiative comment update will be a measure of how many times a user has created a new comment (i.e. not edited a comment) for each item, yes?

[ferrisoxide]

@emily-humphreys Fix for the reports (as well as UI changes per #507) are up on staging

[ferrisoxide]

Deployed to production