EventideSystems / tool_for_systemic_change

GNU Affero General Public License v3.0
6 stars 0 forks source link

User creation bugs #668

Closed emily-humphreys closed 2 years ago

emily-humphreys commented 2 years ago

Users added to the system are not receiving emails

A clear and concise description of what the bug is. When a user is created they are not receiving emails with their invitation This is also happening for 'resend invitation' and 'reset password'

To Reproduce

Steps to reproduce the behavior: _1. Create User / or resend invitation / or reset password _2. Wait for email _3. Emails don't arrive

Expected behavior

Each action should trigger an email

Question? This might be the moment we re-do the User creation part of the software? Is this a big job? We have a big intake in Feb (15) that we'll need to resolve this for or email password (which is not ideal)

We may need to pause on SDG Card to fix this first?

ferrisoxide commented 2 years ago

@emily-humphreys

I've become less trusting of MailJet in general, but let's move this into something you can control or at least have better visibility over.

We can move over to use MailChimp to manage your outgoing emails. We can leverage off their reputation management to better serve emails to customers, as well as report on what emails get through (and what don't). You'll also should be able to edit the templates used, so you can change the wording of sign-up emails as you see fit.

Mailchimp has excellent support for Ruby (see https://github.com/mailchimp/mailchimp-transactional-ruby). I've used it before and never had an issue.

ferrisoxide commented 2 years ago

@emily-humphreys I'm happy to make this a priority. It will take ~ 3 hours, and I will need access to your MailChimp account.

emily-humphreys commented 2 years ago

Let do this!

Wicked_lab Wickedlab16!

On Tue, Jan 25, 2022 at 9:19 AM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys I'm happy to make this a priority. It will take ~ 3 hours, and I will need access to your MailChimp account.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1020627676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOUVVRNNYYUEY3NUDFLUXXJOTANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys

Hi Em

OK, it looks like you don't have transactional emails as part of your MailChimp account. The base pricing, which gives you thousands of emails a month, is $20US per month on top of whatever you are currently paying for MailChimp.

There is a trial offer, which gives you 500 free emails. I haven't activated that, but I can if this is the path you want to go down.

As a comparison, the Mailjet equivalent offer is ~ $25. I think it'd probably be better to keep everything under MailChimp anyway (plus it's cheaper).

ferrisoxide commented 2 years ago

@emily-humphreys

Do you want me to proceed with this? I don't think there is a way forward that doesn't add monthly costs. There is a cheaper option, to run everything up in AWS SES, but the upfront cost would be probably double this (and the solution would not be under your direct control).

emily-humphreys commented 2 years ago

Yes absolutely. I’m just away from my computer but can set it up tonight. What’s the membership level we need to set up?

On Wed, 26 Jan 2022 at 3:01 pm, Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys

Do you want me to proceed with this? I don't think there is a way forward that doesn't add monthly costs. There is a cheaper option, to run everything up in AWS SES, but the upfront cost would be probably double this (and the solution would not be under your direct control).

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1021852272, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOWO24K47J4H3EN2VQDUX52LJANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys Nothing needed right now, as we have 500 free emails to use up first. I just wanted to make sure you were happy going down this path.

All good.

emily-humphreys commented 2 years ago

Fantastic

On Wed, 26 Jan 2022 at 9:57 pm, Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys Nothing needed right now, as we have 500 free emails to use up first. I just wanted to make sure you were happy going down this path.

All good.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1022110995, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOUCCSSVJZ5YOTXE4Z3UX7LDXANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys

Am just in the process of setting up Mandril/MailChimp. You should have received an email via emily@wickedlab.com.au

I will need to access your DNS records as well, to set up DKIM settings, etc to formally authenticate your domain. If you can send me the credentials for this (via txt?) or otherwise we can screenshare and I can walk you through it.

ferrisoxide commented 2 years ago

@emily-humphreys

I will need to access your DNS records as well, to set up DKIM settings, etc to formally authenticate your domain

We need to sort this out ASAP. If you are looking to take an large intake on Feb 5 we are running out of time.

If you are comfortable setting up DKIM and SPF settings yourself, the details for what needs to be added to your DNS config can be found here:

https://mandrillapp.com//settings/sending-domains

Otherwise I'm happy to do it, but I will need the user name and password for namecheap.

ferrisoxide commented 2 years ago

@emily-humphreys

Sorry, Feb 15... not sure why I had Feb 5 in my head. Slightly less immediate, but still not something I want to be doing a few days beforehand.

ferrisoxide commented 2 years ago

@emily-humphreys

Hey Em

Well, we had some success yesterday, but I'm currently blocked by an issue with Namecheap. The MailChimp setup requires both DKIM and SPF records to validate your account, but only the DKIM setting has taken - and I have no idea why.

I've lodged a support ticket with Namecheap, and the response should go to your Gmail account. Fingers crossed there's a simple solution.

emily-humphreys commented 2 years ago

Great and thank you.

Look forward to updates :)

On Thu, Feb 3, 2022 at 9:51 AM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys

Hey Em

Well, we had some success yesterday, but I'm currently blocked by an issue with Namecheap. The MailChimp setup requires both DKIM and SPF records to validate your account, but only the DKIM setting has taken - and I have no idea why.

I've lodged a support ticket with Namecheap, and the response should go to your Gmail account. Fingers crossed there's a simple solution.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1028450448, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOXTDUI3W5TKEROMNM3UZG377ANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

DEV NOTES

Had response from Namecheap. Issue ended up being the CNAME set for @ (CNAMEs block TXT and related records on same host). Swapped CNAME for an ALIAS and everything is now working fine.

emily-humphreys commented 2 years ago

Brilliant

On Thu, 3 Feb 2022 at 5:35 pm, Tom Tuddenham @.***> wrote:

DEV NOTES

Had response from Namecheap. Issue ended up being the CNAME set for @ (CNAMEs block TXT and related records on same host). Swapped CNAME for an ALIAS and everything is now working fine.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1028667466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOXA5BVKOHGWZWEFXYLUZISKBANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys You should have received a test email from the system (as an invitation). Are you able to confirm please?

We can't send to email addresses outside of wicked.com.au until the account is upgraded to a paid account. When you are ready to, can you please log into Mandrill (using your MailChimp credentials) and upgrade to paid plan (the most basic should be fine).

You can get to the Mandrill dashboard from here: https://mandrillapp.com/

ferrisoxide commented 2 years ago

@emily-humphreys I should have noted, the email has been sent to emily@wickedlab.com.au

emily-humphreys commented 2 years ago

It hasn’t arrived yet… will let you know when it has On Thu, 3 Feb 2022 at 5:58 pm, Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys I should have noted, the email has been sent to @.***

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1028680511, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZORSPO4XEJBBRO5Y24TUZIVA7ANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

Hmm... it's recorded in the API as "delivered". Maybe check the spam folder for emily@wickedlab.com.au

ferrisoxide commented 2 years ago

@emily-humphreys OK, it looks like it's all working. If you upgrade to a paid plan I'll be able to send emails to other account (e.g. my own GMail account) - we'll need this for fixing the content and for QA.

emily-humphreys commented 2 years ago

Great its all working I'm not completely clear what I need to do in terms of accounts/content? What do I need to upgrade to?

On Thu, Feb 3, 2022 at 7:00 PM Tom Tuddenham @.***> wrote:

Closed #668 https://github.com/ferrisoxide/wicked_software/issues/668.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#event-6000980810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOTLYQMHCNQHACPVWQ3UZI4JFANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

Ah, it should be "1 Block" of transactional emails (25,000 emails p/m for $20US).

If it's a hassle we can hold off and I'll try to figure out how to check the content via the API - though we will need to have a paid account for QA.

If it's not clear, give me a call and I'll walk you through it.

ferrisoxide commented 2 years ago

@emily-humphreys I made the assumption that you already had a paid account with MailChimp. Am I incorrect? You need a standard account minimum to be able to use the transactional email service, which ends up being an additional cost.

emily-humphreys commented 2 years ago

Great. We have a free account so leave it with me and will investigate in the AM

On Thu, 3 Feb 2022 at 7:16 pm, Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys I made the assumption that you already had a paid account with MailChimp. Am I incorrect? You need a standard account minimum to be able to use the transactional email service, which ends up being an additional cost.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1028735175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOR7AEYHYW5PF23OLILUZI6FXANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

emily-humphreys commented 2 years ago

Hi Tom,

We are all upgraded! Shall I send through words for the new invitation?

Cheers Emily

On Thu, Feb 3, 2022 at 7:26 PM Emily Humphreys @.***> wrote:

Great. We have a free account so leave it with me and will investigate in the AM

On Thu, 3 Feb 2022 at 7:16 pm, Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys I made the assumption that you already had a paid account with MailChimp. Am I incorrect? You need a standard account minimum to be able to use the transactional email service, which ends up being an additional cost.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1028735175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOR7AEYHYW5PF23OLILUZI6FXANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

NOTES TO QA

@emily-humphreys @SishaMish New email system is up on staging and ready for QA.

@SishaMish A trick you can use to signup or send invitations for different users but using the same email address. With GMail accounts you can add a +x at the end of the first part of your email, e.g. you can have two users with the emails ferrisoxide+1@gmail.com and ferrisoxide+2@gmail.com and both will be sent to the base ferrisoxide@gmail.com address.

NB The main thrust of this is to test invitations. When you are inviting a user from the 'Users' page, remember to select an Account context first. You may also need to check that the account can have new users added (set Max users to 0 to allow unlimited Users per Account).

You will need to make sure that any links in the email work as intended, and that the text / layout is correct.

Emily has asked for the invitation emails to appear like this:

image

We probably should also check the email contents for signing up and for password reset / forgot password.

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys This has been tested and all checks out, the email appears as above and all the links work.

One point is that the Set Password page that the user is taken to after accepting the invitation is very plain and lacking any welcoming message or branding. Screen Shot 2022-02-05 at 6 07 09 pm

ferrisoxide commented 2 years ago

@SishaMish @emily-humphreys The layout for the "Set your password" has been fixed.

emily-humphreys commented 2 years ago

Hi team, This is working perfectly. Great tips on the +1 with gmail account!

Two tiny tweeks re layout:

  1. Can we have Wicked Lab (rather than WickedLab) as the sender?
  2. On the Create / Reset Password page - Can we centre the button?

Thanks team!

On Sat, Feb 5, 2022 at 7:50 PM Tom Tuddenham @.***> wrote:

@SishaMish https://github.com/SishaMish @emily-humphreys https://github.com/emily-humphreys The layout for the "Set your password" has been fixed.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1030587157, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOQU7KZME6YINPN25HTUZTTW3ANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys @SishaMish

Re

  1. Can we have Wicked Lab (rather than WickedLab) as the sender?
  2. On the Create / Reset Password page - Can we centre the button?

Both changes are up on staging.

emily-humphreys commented 2 years ago

This looks tip top and works beautifully!

1 final tweak that I think I missed last time: Can we have the title of the email be....

Invitation instruction: Tool for Systemic Change

ferrisoxide commented 2 years ago

@emily-humphreys

Invitation instruction: Tool for Systemic Change

Sure, though "Invitation instructions: Tool for Systemic Change" is probably more correct (noun plural has slightly different meaning than singular).

You OK with "Invitation instructions: Tool for Systemic Change"

emily-humphreys commented 2 years ago

Yep AOK. Thanks for the pick up

On Tue, Feb 8, 2022 at 10:56 AM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys

Invitation instruction: Tool for Systemic Change

Sure, though "Invitation instructions: Tool for Systemic Change" is probably more correct (noun plural has slightly different meaning than singular).

You OK with "Invitation instructions: Tool for Systemic Change"

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1032082308, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZORFI27S4JS36F675YDU2BPNHANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys @SishaMish

Change to invitation email subject up on staging and ready for QA

emily-humphreys commented 2 years ago

Looks great and ready for production :)

On Tue, Feb 8, 2022 at 11:13 AM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys @SishaMish https://github.com/SishaMish

Change to invitation email subject up on staging and ready for QA

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1032094219, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZORGZBH6TGVRCWASGMTU2BRK5ANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys Have tested on MacOS/Chrome - on the 'set your password' page, the 'set my password' button is still not centred. Screen Shot 2022-02-08 at 12 06 57 pm

emily-humphreys commented 2 years ago

thanks Lisa for this excellent pick up

On Tue, Feb 8, 2022 at 12:07 PM SishaMish @.***> wrote:

@ferrisoxide https://github.com/ferrisoxide @emily-humphreys https://github.com/emily-humphreys Have tested on MacOS/Chrome - on the 'set your password' page, the 'set my password' button is still not centred. [image: Screen Shot 2022-02-08 at 12 06 57 pm] https://user-images.githubusercontent.com/39264459/152901455-0480d4de-eb27-4915-9125-e908d04e17af.png

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1032122841, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOXNCMERJNGOTE45VATU2BXWZANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys

Have just tested on Firefox with the same result. Sorry Tom! Screen Shot 2022-02-08 at 12 51 00 pm

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys Have re-tested now on Chrome and Firefox and I give it a pass. Ready for production. :) Screen Shot 2022-02-08 at 1 09 14 pm

emily-humphreys commented 2 years ago

🙏🙏

On Tue, Feb 8, 2022 at 1:09 PM SishaMish @.***> wrote:

@ferrisoxide https://github.com/ferrisoxide @emily-humphreys https://github.com/emily-humphreys Have re-tested now on Chrome and Firefox and I give it a pass. Ready for production. :) [image: Screen Shot 2022-02-08 at 1 09 14 pm] https://user-images.githubusercontent.com/39264459/152907645-aa170742-4ee2-4d95-b88a-abb0b3bdf528.png

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/668#issuecomment-1032153311, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZORTZ5QCB6Q3KVKH6D3U2B67XANCNFSM5MUCCOPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

Deployed to production. Closing.