search

EventideSystems / tool_for_systemic_change

GNU Affero General Public License v3.0
6 stars 0 forks source link

Update SDG Targets to new shorten version #756

Closed emily-humphreys closed 2 years ago

emily-humphreys commented 2 years ago

Describe the task

Update the 169 SDG targets to a new shorted version and include an extended version in the (i) pop up

Success Criteria

When users select the SDGs Target list to begin/continue mapping they will see a shortened version of the full

Additional Notes

Please see attached Crosswalk spreadsheet

Related Issues

Are you able to let me know how many hours this might be SDG Targets - cross walk.xlsx ?

ferrisoxide commented 2 years ago

@emily-humphreys

Just to rephrase this, so I'm sure I understand what are are after:

Given the user is viewing an initiative data entry page for an SDGs card, the checkbox label that previously said "1.1 By 2030, eradicate extreme poverty for all people everywhere, currently measured as people living on less than $1.25 a day" will now read "1.1 Eradicate extreme poverty".

If I hover over the label "1.1 Eradicate extreme poverty", a tooltip dialog will appear containing the original text "1.1 By 2030, eradicate extreme poverty for all people everywhere, currently measured as people living on less than $1.25 a day".

When I click on the (i) symbol next to the checklist item the info dialog will appear with the heading using the original text "1.1 By 2030, eradicate extreme poverty for all people everywhere, currently measured as people living on less than $1.25 a day".

All other checklist items (aka SGD targets) will similarly be updated, per the attached spreadsheet.

Do I have this correct?

ferrisoxide commented 2 years ago

@emily-humphreys Ah, the (i) popup is the artefact present on the initiatives for transition cards. Got it. Amended previous note

ferrisoxide commented 2 years ago

@emily-humphreys

OK, now I'm less clear. By " full target wording" do you mean the text from WIkipedia? - i.e. if the user clicks on the (i) icon for the "1.1 Eradicate extreme poverty" checklist item they will be presented with the following text:

The full text of Target 1.1 is: "By 2030, eradicate extreme poverty for all people everywhere, currently measured as people living on less than $1.90 a day."[1]

Target 1.1 includes one indicator: Indicator 1.1.1 is the "Proportion of population living below the international poverty line aggregated by sex, age, employment status, and geographical location (urban/rural)".[4]

The pace of reducing extreme poverty started off well with 2010 (15.7 percent), 2015 (10 percent), 2019 (8.2 percent) and is projected in 2020 at (8.4 to 8.8 percent). This is because the COVID-19 pandemic is reversing the poverty reduction cycle.[21]: 3 

The world's workers living in extreme poverty fell, from 14.3 to 8.3 to 7.1 percent in 2010, 2015 and 2019, respectively.[21]

NB The same will apply for all other checklist items, per the Wikipedia page details in the attached spreadsheet above.

emily-humphreys commented 2 years ago

Hi Tom, its so much simpler than that

Replace existing wording with new shorten wording (column A) Add (i) /description which is Original wording (column B)

Does that make sense? Cheers

On Wed, May 25, 2022 at 5:19 PM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys

OK, now I'm less clear. By " full target wording" do you mean the text from WIkipedia. I.e. if the user clicks on the (i) icon for the "1.1 Eradicate extreme poverty" checklist item they will be presented with the following text:

The full text of Target 1.1 is: "By 2030, eradicate extreme poverty for all people everywhere, currently measured as people living on less than $1.90 a day."[1] https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#cite_note-:172-1

Target 1.1 includes one indicator: Indicator 1.1.1 is the "Proportion of population living below the international poverty line https://en.wikipedia.org/wiki/Poverty_line aggregated by sex, age, employment status, and geographical location https://en.wikipedia.org/wiki/Location (urban https://en.wikipedia.org/wiki/Urban_area/rural https://en.wikipedia.org/wiki/Rural_area)".[4] https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#cite_note-:3-4

The pace of reducing extreme poverty started off well with 2010 (15.7 percent), 2015 (10 percent), 2019 (8.2 percent) and is projected in 2020 at (8.4 to 8.8 percent). This is because the COVID-19 pandemic https://en.wikipedia.org/wiki/COVID-19_pandemic is reversing the poverty reduction cycle.[21] https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#cite_note-:1-21: 3

The world's workers living in extreme poverty fell, from 14.3 to 8.3 to 7.1 percent in 2010, 2015 and 2019, respectively.[21] https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#cite_note-:1-21

NB The same will apply for all other checklist items, per the Wikipedia page details in the attached spreadsheet above.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1136907955, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOVNYZR2U532AHHVWPDVLXLPXANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

(i) /description

Meaning, the tooltip when hovering over the icon? As in, where it currently says "More information" you would expanded form of the checklist item's title?

image

The issue here is that the (i) icon only appears if you have a description set for the characteristic. This is fine, but I'll have to create a blank "Description" for each characteristic (the contents of the dialog displayed when you actually click on the icon), which you can fill in at your leisure.

One point thought, is that this runs slightly contrary to the original intent of the icon. It's a link to "More information" about a characteristic, hence its tooltip value. Changing it is fine, though what do you want to happen for Transition Card characteristics, which don't have the short/long form name issue?

Summary:

emily-humphreys commented 2 years ago

We just use the feature as is with no change. I've made the change for 10.1 with the shorten name and added the Full text in the (i)

Here are

Screen Shot 2022-05-26 at 4 34 04 pm Screen Shot 2022-05-26 at 4 34 13 pm
ferrisoxide commented 2 years ago

So you did want the content from the wiki pages? I'm totally confused, but I guess this ticket can be closed?

ferrisoxide commented 2 years ago

@emily-humphreys

Not sure if you realise this, but you can link to anchors within the wiki pages. For instances, the link in "Description" for the 10.1 target could have this link:

https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#Target_1.1:_Eradicate_extreme_poverty

Which will take the user directly to that section of the document.

emily-humphreys commented 2 years ago

Thanks, Tom - that's a brilliant idea. Originally I didn't even think of putting the wiki link in - but you inspired me :)

On Thu, May 26, 2022 at 5:54 PM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys

Not sure if you realise this, but you can link to anchors within the wiki pages. For instances, the link in "Description" for the 10.1 target could have this link:

https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#Target_1.1:_Eradicate_extreme_poverty

Which will take the user directly to that section of the document.

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1138290923, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOS7FU3RRM2KYV2KR7TVL4YJ7ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

But... you did put the link in. There is a link under the More information heading in your example. The link works, but it takes you to the https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1 page, not the heading within that page (per the URL I quoted before).

ferrisoxide commented 2 years ago

Originally

Ah, sorry. I get it now. All good. Do you still want any changes, or can we close this ticket?

emily-humphreys commented 2 years ago

Circling back to this - I know there is no new feature development - but the ticket was really to do this in an automated way. Are you able to write a script to replace the Targets and auto add the (i) description based on the spreadsheet?

On Mon, May 30, 2022 at 1:18 PM Emily Humphreys @.***> wrote:

Are you able to do this in an automated way? i.e I don't want to have to do this manually for the 169 targets

On Fri, May 27, 2022 at 9:36 AM Tom Tuddenham @.***> wrote:

Originally

Ah, sorry. I get it now. All good. Do you still want any changes, or can we close this ticket?

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1139162956, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOS7ZVVZY5YJ7W2WL5DVMAGZ5ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys

I'm still unclear what you are after. Does make sense?

Given I am viewing the data entry page for an Initiative within an SDGs card (i.e. the checklist) And I have opened up Goal 10 And I can see the checklist item labelled "10.1 Reduce income inequalities" (i.e. the short form for 10.1) When I hover the mouse over the (i) symbol next to the checklist item Then the tooltip will display with the text "10.1 By 2030, progressively achieve and sustain income growth of the bottom 40 per cent of the population at a rate higher than the national average" (i.e. the long form)

Acceptance criteria:

On the data entry page for an Initiative within an SDGs card:

Notes:

The presentation of the (i) icon is dependent upon there being a description associated with each Characteristic. In the case of SDG-based Characteristic there generally isn't a description (hence the icon doesn't display).

What do you want the description of each SDG-based Characteristic to be? Do you want just some placeholder text, or do you want me to copy the details from the relevant wiki pages?

emily-humphreys commented 2 years ago

Acceptance criteria:

On the data entry page for an Initiative within an SDGs card:

  • [ ] MUST display short form for all targets (aka Characteristics) on SDGs cards (per the spreadsheet)
  • [ ] MUST display long form for all targets (aka Characteristics) on SDGs cards (per the spreadsheet) when hovering over the (i) associated with each > Correct Notes:

The presentation of the (i) icon is dependent upon there being a description associated with each Characteristic. In the case of SDG-based characteristics (targets) there generally isn't a description (hence the icon doesn't display).

Adding back in previous screenshot example of when I have manually created this for a Target.

Screen Shot 2022-05-26 at 4 34 13 pm Screen Shot 2022-05-26 at 4 34 04 pm

What do you want the description of each SDG-based Characteristic to be? Do you want just some placeholder text, or do you want me to copy the details from the relevant wiki pages?

This description would

The full text of Target

10.1 By 2030, progressively achieve and sustain income growth of the bottom 40 per cent of the population at a rate higher than the national average (take from Column B / Orginal)

More information https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1 (or whatever Doal it sits within 1, 2, 3 etc)

Check out Target 10.1 and Description to see what I've done to create the pic Note - I appreciate there is no new features but I want to know is there a way to import this so I don't have to do it manually

ferrisoxide commented 2 years ago

@emily-humphreys k++

Will probably take a couple of hours to import and then get Lisa to check. Once it's done we can roll it out to production with no dramas

emily-humphreys commented 2 years ago

Fabulous

On Tue, Jun 7, 2022 at 4:20 PM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys k++

Will probably take a couple of hours to import and then get Lisa to check. Once it's done we can roll it out to production with no dramas

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1148265049, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOUQOGCU5FXGGCGXGNDVN3WK7ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

@emily-humphreys @SishaMish This is on staging and ready for QA

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys

This is QAd and ready for production.

One question though - when clicking the Wikipedia link in the pop up, should the Wiki page open in a new window? It currently opens in the same window, and the user has to use the back arrow to return to the Wicked app.

emily-humphreys commented 2 years ago

Hi team - yes I think in a new window for clicking on it.

Also the "more information' hover over in Chrome sticks around when the dialogue box comes up (stays over the wiki link)

Screen Shot 2022-06-10 at 1 42 17 pm
ferrisoxide commented 2 years ago

@emily-humphreys @SishaMish

Changes per feedback:

These changes are on staging and ready for QA

emily-humphreys commented 2 years ago

This is all working great - ready for production

On Fri, Jun 10, 2022 at 11:31 PM Tom Tuddenham @.***> wrote:

@emily-humphreys https://github.com/emily-humphreys @SishaMish https://github.com/SishaMish

Changes per feedback:

  • Tooltip for "More Information" link now hides when the dialog opens.
  • Tooltip for "Edit comments" link also now hides
  • Wikipedia link in dialog now opens in a separate browser tab

These changes are on staging and ready for QA

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1152395116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOTRFBP64TDG5SEVOJTVONDD5ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

emily-humphreys commented 2 years ago

I love your idea of an anchored link to the target ✅

On Thu, 26 May 2022 at 9:48 pm, Tom Tuddenham @.***> wrote:

But... you did put the link in. There is a link under the More information heading in your example. The link works, but it takes you to the https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1 https://en.wikipedia.org/wiki/Sustainable_Development_Goal_1#Target_1.1 page, not the heading within that page (per the URL I quoted before).

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1138514165, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOQH3RH7F2KLSDAXO5LVL5T27ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

emily-humphreys commented 2 years ago

Are you able to do this in an automated way? i.e I don't want to have to do this manually for the 169 targets

On Fri, May 27, 2022 at 9:36 AM Tom Tuddenham @.***> wrote:

Originally

Ah, sorry. I get it now. All good. Do you still want any changes, or can we close this ticket?

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/756#issuecomment-1139162956, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOS7ZVVZY5YJ7W2WL5DVMAGZ5ANCNFSM5WULRMJA . You are receiving this because you were mentioned.Message ID: @.***>

ferrisoxide commented 2 years ago

Are you able to do this in an automated way? i.e I don't want to have to do this manually for the 169 targets

Probably. There seems to be a pattern to the pages on wikipedia. This would be a separate ticket though - I will have to look into it further.

ferrisoxide commented 2 years ago

@emily-humphreys

Are you able to do this in an automated way? i.e I don't want to have to do this manually for the 169 targets

I've created a new ticket for this here: #815